array in array in array and also one

Question

I need to write a factorial using an array but the problem is only Show 120 five times and what i want is 1, 2, 6, 24, 120 showing in the textBox

int factProg = 1;
public void factArray(int[] arr)
{   
    for (int i = 0; i < arr.Length; i++)
    {
        factProg = factProg * arr[i];
    }
}



int[] arr = {1,2,3,4,5};

for (int i = 0; i < arr.Length; i++)
{
    factArray(arr);
    textBox1.Text += Convert.ToString(factProg);
    textBox1.Text += Environment.NewLine;
}

What are you trying to do? Does this even compile? UPD: forgot about methods inside methods, but that is some amazing code style. — user4331373
– user4331373, Commented Nov 17, 2017 at 8:57
You are having two loops, ofcourse it will print 120 five times — Ofir Winegarten
– Ofir Winegarten, Commented Nov 17, 2017 at 8:58
i want factorial from 1 to 5 showing in the textbox @someone using this method — John
– John, Commented Nov 17, 2017 at 8:58
Rather than calculating a factorial for each n from 1 to 5, you calculate the product of array [1,2,3,4,5] 5 times. You could use int fact(int i)=>i*fact(i-1); and then in the for loop fact(arr[i]) instead of factArray(arr) — user4331373
– user4331373, Commented Nov 17, 2017 at 8:59

PaulF · Accepted Answer · 2017-11-17 09:36:07Z

2

Simply put - your factArray method always calculates the factorial for the length of the whole array which is a fixed size. You need to pass an extra parameter - being the position in the array you want to stop calculating

Try this if you want to calculate using your array :

int factProg;
public void factArray(int[] arr, int len)
{   
  factProg = arr[0];
  for (int i = 1; i <= len; i++)
  {
    factProg = factProg * arr[i];
  }
}

int[] arr = {1,2,3,4,5};

for (int i = 0; i < arr.Length; i++)
{
  factArray(arr, i);
  textBox1.Text += Convert.ToString(factProg);
  textBox1.Text += Environment.NewLine;
}

You would need to add a check in the method that you are not exceeding the array length.

edited Nov 17, 2017 at 9:36

answered Nov 17, 2017 at 9:21

PaulF

6,7932 gold badges20 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Hans Keﬆing Over a year ago

Code cleanup suggestion: make factProg local to the method and return its value.

PaulF Over a year ago

@HansKesting: I deliberately kept the code as close as possible to the original - but that's not the only thing I would do to clean up the code.

Ram Venkat · Accepted Answer · 2017-11-17 09:33:22Z

0

Please find the code below

public static void FactorialJohn(int[] arr)
            {          

                List<int> Resarr = new List<int>();
                arr.ToList().ForEach(x => Resarr.Add(Enumerable.Range(1, x).Aggregate((a, b) => a * b)));

                foreach (var item in Resarr)
                {
                    Console.WriteLine(item);
                }
            }

The above code gets you factorial of every element in the array.

answered Nov 17, 2017 at 9:33

Ram Venkat

941 silver badge11 bronze badges

1 Comment

Ram Venkat Over a year ago

@John The above code will get you the same result using Linq

Collectives™ on Stack Overflow

array in array in array and also one

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related