Notification with cloud function firebase, JavaScript

Question

I am following a tutorial to deploy a function to firebase. when I deploy I get an unknown error whereas the tutor doesn't. I have looked through this line for line and it's exact. Can anyone else shed any light on this?

// The Cloud Functions for Firebase SDK to create Cloud Functions and   setup triggers.
const functions = require('firebase-functions');

// The Firebase Admin SDK to access the Firebase Realtime Database. 
 const admin = require('firebase-admin');
admin.initializeApp(functions.config().firebase);
const ref = admin.database().ref


exports.sendPushNotification =        functions.database.ref('/posts/{postId}/question').onWrite(event => {
const payload = {
notification: {
  title: 'A Question has been posted',
  body: 'Check out the question posted ',
  badge: '1',
  sound: 'default',
}
};
return admin.database().ref('fcmToken').once('value').then(allToken => {
if (allToken.val()) {
    const token = Object.keys(allToken.val());
    return admin.messaging().sendToDevice(token, payload).then(response => {

  });
};
});
});

Your code deploys successfully for me. Can you post the text for the deploy error you are getting? — Bob Snyder
– Bob Snyder, Commented Jan 6, 2018 at 16:37
Ah, Thank you for your reply @BobSnyder I was getting an error each time I ran the code when I ran it to get the error message for you it ran successfully. I didn't change a thing in it. I did, however, add a fcmToken post in my database, but I am not sure if that has anything to do with it because the tutor didn't have it in when he ran the code. again thank you for your time with it. — Tony Merritt
– Tony Merritt, Commented Jan 6, 2018 at 16:44

Bob Snyder · Accepted Answer · 2018-01-06 16:48:59Z

1

Cloud Functions expects a returned Promise or value. Add a return for the case where there is no token value found in the database:

exports.sendPushNotification = functions.database.ref('/posts/{postId}/question').onWrite(event => {
  const payload = {
    notification: {
      title: 'A Question has been posted',
      body: 'Check out the question posted ',
      badge: '1',
      sound: 'default',
    }
  };
  return admin.database().ref('fcmToken').once('value').then(allToken => {
    if (allToken.val()) {
      const token = Object.keys(allToken.val());
      return admin.messaging().sendToDevice(token, payload).then(response => {

      });
    } else {
      return null; // <= ADDED
    }
  });
});

answered Jan 6, 2018 at 16:48

Bob Snyder

38.3k6 gold badges114 silver badges160 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tony Merritt Over a year ago

Excellent this makes sense. Thank you I will add that into my code. Again thank you for your time on this. All the best

Collectives™ on Stack Overflow

Notification with cloud function firebase, JavaScript

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related