Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1

Question

 public static String s1 = "team A won the match historically to clinch series which made surprise around the world ";
 public static String s2 = "He did his part";

 t1=s1.length();
 t2=s2.length();
 t3=Math.abs(t1-t2); 

  for(i=0;i<t3;i++)
  {
      Sub_string.add(s1.substring(i,t2++));
  }

How can I solve this?

actually Sub_string is a arraylist to which i add substrings. — KNsiva
– KNsiva, Commented Feb 4, 2011 at 6:36
Paste the exact program. This code works. Sub_string is [team A won the , eam A won the m, ...,around the worl, round the world] — Nishant
– Nishant, Commented Feb 4, 2011 at 6:48

Aba Dov · Accepted Answer · 2011-02-04 07:11:53Z

1

tried it. doesn't seem to throw an exception

I guess you defined your list to have max size? if you define it like this it will work.

public class TestCode {
    public static String s1 = "team A won the match historically to clinch series which made surprise around the world ";
     public static String s2 = "He did his part";
    /**
     * @param args
     */
    public static void main(String[] args) {
        // TODO Auto-generated method stub
         ArrayList<String> Sub_string = new ArrayList<String>();  

        int t1=s1.length();
        int t2=s2.length();
        int t3=Math.abs(t1-t2); 


        try {
            for(int i=0;i<t3;i++)
              {
                  Sub_string.add(s1.substring(i,t2++));
              }
        } catch (Exception e) {
            System.err.println();

        }

    }

}

edited Feb 4, 2011 at 7:11

answered Feb 4, 2011 at 6:52

Aba Dov

9624 gold badges12 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

KNsiva Over a year ago

thank u for all of u for making a quick reply..this logic is correct.actually i made a mistake when specifying size of the list..thank u very much Aba Dov..

Aba Dov Over a year ago

@KNsiva Glad I was able to answer your question :)

diciu · Accepted Answer · 2011-02-04 06:56:44Z

1

Code derived from your pseudocode, with the input strings you provided, will not throw any exception.

The exception you posted (StringIndexOutOfBoundsException: String index out of range: -1) is thrown when substring is called with beginIndex (in your case i) larger then endIndex (in your case t2).

You will also get a StringIndexOutOfBoundsException when you call your code with a s1 that is shorter then s2.

answered Feb 4, 2011 at 6:56

diciu

29.4k4 gold badges54 silver badges69 bronze badges

Comments

aman_novice · Accepted Answer · 2011-02-04 07:40:26Z

The following code would serve your purpose... gives no problem. Prints sum as 73 and a designer output..;) Hope its helpful!!!!

import java.util.ArrayList;
public class Trial {
    public static String s1 = "team A won the match historically to clinch series which made surprise around the world ";
     public static String s2 = "He did his part";

    public static void main(String[] args) {

         ArrayList<String> Sub_string = new ArrayList<String>();  

        int t1=s1.length();
        int t2=s2.length();
        int t3=Math.abs(t1-t2); 

        try {
            for(int i=0;i<t3;i++)
                  Sub_string.add(s1.substring(i,t2++));

        Object ia[] = Sub_string.toArray();
        for(int i=0; i<ia.length; i++)
            System.out.println(ia[i]);

        } catch (Exception e) {
            System.err.println();

        }

    }

}

Collectives™ on Stack Overflow

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: -1

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related