JavaScript - Replacing for loop with array helpers

Question

So today I was learning about some ES6 array helpers, and I wanted to change my existing for loops with them, but I can not get same result as i was taking with for loop

function comment(){
    let index;
    for(let i = 0; i < commentArray.length; i++){
        if(commentArray[i]._id == req.params.commentId){
            index = commentArray.indexOf(commentArray[i]);
        }
    }
    return index;
}
var com = comment();

It is nodejs and I am trying to get element index from database, and than pull from it, my code works just fine, but I want to change it with array helper, I guess I need find helper, but I can not make it work!

And what's your code with "array helpers"?

user202729
– user202729

2018-04-06 08:12:16 +00:00
Commented Apr 6, 2018 at 8:12 — user202729
– user202729, Commented Apr 6, 2018 at 8:12

31piy · Accepted Answer · 2018-04-06 08:13:24Z

3

You can replace your for loop with this one-liner which uses Array#findIndex:

let index = commentArray.findIndex(comment => comment._id === req.params.commentId);

When this line executes, it will assign the index of comment, which has _id attribute same as req.params.commentId.

answered Apr 6, 2018 at 8:13

31piy

23.9k6 gold badges51 silver badges69 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Toko Goshadze Over a year ago

works pretty well! just change triple equal sign to double, because with triple it gave me silly error when index equaled -1, i guess that is because comment._id is coming from db as string <3 thanks

31piy Over a year ago

@TokoGoshadze -- don't get confused. Read the difference here and then make the decisions.

Suren Srapyan · Accepted Answer · 2018-04-06 08:13:24Z

3

If you want to find the index of the item in the array based on some condition, you can use findIndex function

commentArray.findIndex(comment => comment._id === req.params.commentId)

Also with your current code with for loop, I think you need return the index as soon as it is found and not let the loop iterate till the end.

for(let i = 0; i < commentArray.length; i++){
    if(commentArray[i]._id == req.params.commentId){
        return commentArray.indexOf(commentArray[i]);
    }
}

answered Apr 6, 2018 at 8:13

Suren Srapyan

68.9k14 gold badges128 silver badges119 bronze badges

1 Comment

Toko Goshadze Over a year ago

thanks for answer, it worked, and ill keep in mind to return index when its found next time!

Collectives™ on Stack Overflow

JavaScript - Replacing for loop with array helpers

2 Answers 2

2 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related