Bubblesorting an array with String Manipulation and Functions

Question

Question

So i've been trying to code a 2-stage program that has a string(It's a constant string. It's given.) and does:

Find items that starts with a specified letter,
Sort items in that string alphabetically.

Problem

I need help with the second part of my program, because first part is doing fine. I should see the cities alphabetically sorted when I execute my code. But instead I see this nonsense.

I'm a complete noob and I'm having problems at every bit of string/character manipulation related subject. So any help about anything will be appreciated.

Here is my code:

#include <stdio.h>
#include <string.h>
#include <ctype.h>

void sortStartwB(const char strSehir[]);
void sortCities(const char strSehir[]);

int main()
{
    const char strSehir[100] = "Bursa Yozgat Canakkale Balikesir Adana Eskisehir Bilecik";
    sortStartwB(strSehir);
    sortCities(strSehir);
    return 0;
}

void sortStartwB(const char strSehir[])
{
    char strNew[100];
    strcpy(strNew, strSehir);
    char *ptrSehir;
    char strBsehir[50] = {}; 

    ptrSehir = strtok(strNew, " ");


    while (ptrSehir != NULL)
    {
        if (strncmp(ptrSehir, "B", 1) == 0)
        {
            strcat(strBsehir, ptrSehir);
            strcat(strBsehir, " ");
        }
        ptrSehir = strtok(NULL, " ");
    }

    printf("\nb ile baslayan sehirler : \n%s\n", strBsehir);
}

void sortCities(const char strSehir[])
{
    char strFunc[100];
    char *strSorted[100];
    int i = 0;

    char temp[50];

    strcpy(strFunc, strSehir);

    strSorted[i]=strtok(strFunc, " ");

    while (strSorted[i] != NULL)
    {
        strSorted[++i] = strtok(NULL, " ");
    }

    for (int j=0; j<6; j++)
    {
        for (int k=j+1; k<7; k++)
        {
            if (strcmp(strSorted[j], strSorted[k]) > 0)
            {
                strcpy(temp, strSorted[j]);
                strcpy(strSorted[j], strSorted[k]);
                strcpy(strSorted[k], temp);
            }
        }
    }

    for (int x=0; x < 7; x++)
    {
        printf("\n%s", strSorted[x]);
    }
}

Sorry for the initializing variables bad and also writing stuff in non-English but this piece of code meant to be my worksheet and English is not my native. Peace

Avoid adding information that is not relevant to your question, read How to Ask — eyllanesc
– eyllanesc, Commented May 28, 2018 at 1:44
Compares 2 strings by n characters. strncmp(ptrSehir, "B", 1) looks if the ptrSehir's first character is "B". — Ertuğrul Gülümcan
– Ertuğrul Gülümcan, Commented May 28, 2018 at 10:59
Only because this is a final exam preparation worksheet and i didn't learn that in our lessons. I'll look up for it, thank you. — Ertuğrul Gülümcan
– Ertuğrul Gülümcan, Commented May 28, 2018 at 11:23

Joël Hecht · Accepted Answer · 2018-05-28 06:33:23Z

1

The strok returns a pointer in the original string. When you sort the cities array, you're messing up the original string by rewriting into it words of differents sizes.

What you have to do is copying each city name in a char[] large enough so you can rewrite any other city name on it without messing up other city names.

Here is an example of something that should works :

void sortCities(const char strSehir[])
{
    char strFunc[100];
    char strSorted[100][100];
    char *city;
    int i = 0;

    char temp[50];

    strcpy(strFunc, strSehir);

    for (city = strtok(strFunc, " "); city != NULL; city = strtok(NULL, " "))
        strcpy(strSorted[i++], city);

    for (int j=0; j<6; j++)
    {
        for (int k=j+1; k<7; k++)
        {
            if (strcmp(strSorted[j], strSorted[k]) > 0)
            {
                strcpy(temp, strSorted[j]);
                strcpy(strSorted[j], strSorted[k]);
                strcpy(strSorted[k], temp);
            }
        }
    }

    for (int x=0; x < 7; x++)
    {
        printf("\n%s", strSorted[x]);
    }
}

Aside note : you should replace constants 6, 7 in the loops with something more generic so the same function will work with other numbers of cities.

edited May 28, 2018 at 6:33

answered May 28, 2018 at 5:34

Joël Hecht

1,8431 gold badge18 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ertuğrul Gülümcan Over a year ago

Okay i added numOfCities variable to the program and incremented it in the tokenizing for loop and I think that should do the trick. Thank you for enligthening me.

Collectives™ on Stack Overflow

Bubblesorting an array with String Manipulation and Functions

Question

Problem

Here is my code:

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

Question

Problem

Here is my code:

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related