PHP if condition with strings

Question

I am trying to write would be a simple if condition.

function genderMatch($consumerid1, $consumerid2)
    {
    $gender1=getGender($consumerid1);
    $gender2=getGender($consumerid2);
    echo $gender1;
    echo $gender2;
    if($gender1=$gender2)   
      echo 1;
      return 1;
    else
       echo 0;
       return 0;
}

The output of the getGender function is either a M or F. However, no matter what I do gender1 and gender2 are returned as the same. For example I get this output: MF1

I am currently at a loss, any suggestions?

This earlier answer may help.

Matt Gibson
– Matt Gibson

2011-03-02 22:46:36 +00:00
Commented Mar 2, 2011 at 22:46 — Matt Gibson
– Matt Gibson, Commented Mar 2, 2011 at 22:46

phihag · Accepted Answer · 2011-03-02 22:43:00Z

7

if ($gender1 = $gender2)

assigns the value of $gender2 to $gender1 and proceeds if the result (i.e. the value of $gender2) evaluates to true (every non-empty string does). You want

if ($gender1 == $gender2)

By the way, the whole function could be written shorter, like this:

function genderMatch($cid1, $cid2) {
  return getGender($cid1) == getGender($cid2);
}

answered Mar 2, 2011 at 22:43

phihag

289k75 gold badges475 silver badges489 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mpj.dev · Accepted Answer · 2011-03-02 22:43:35Z

3

You have to put two == for comparison. With only one, as you have right now, you are assigning the value to the first variable.

     if($gender1=$gender2)

would become

   if($gender1==$gender2)

answered Mar 2, 2011 at 22:43

mpj.dev

5,3772 gold badges33 silver badges47 bronze badges

Comments

circusdei · Accepted Answer · 2011-03-02 22:43:39Z

1

this:

if($gender1=$gender2)

should be

if($gender1==$gender2)

notice the extra ='s sign. I think you might also need curly brackets for multiple lines of an if/else statement.

answered Mar 2, 2011 at 22:43

circusdei

1,96712 silver badges29 bronze badges

Comments

cypher · Accepted Answer · 2011-03-02 22:43:48Z

1

Your using the assignment operator = instead of comparsion operators == (equal) or === (identical).
Have a look at PHP operators.

answered Mar 2, 2011 at 22:43

cypher

7,0024 gold badges34 silver badges48 bronze badges

Comments

Kyle · Accepted Answer · 2011-03-02 22:44:46Z

1

You have some structural problems with your code as well as an assignment instead of a comparison.

Your code should look like this:

function genderMatch($consumerid1, $consumerid2){
    $gender1=getGender($consumerid1);
    $gender2=getGender($consumerid2);
    echo $gender1;
    echo $gender2;
    if($gender1==$gender2){ 
      echo 1;
      return 1;
    }else{
       echo 0;
       return 0;
    }
}

Notice the double '=' signs in the if statement. This is a comparison. A single '=' is an assignment. Also, if you want to execute more than 1 line of code with an if/else, you need brackets.

answered Mar 2, 2011 at 22:44

Kyle

22.3k2 gold badges63 silver badges63 bronze badges

Comments

mqchen · Accepted Answer · 2011-03-02 22:47:49Z

0

You are using a single = which sets the variable, ie. the value of $gender1 is set to be the value of $gender2.

Use the === operator instead: if($gender1 === $gender2). It is usually a good idea to do strict comparisons rather than loose comparisons.

Collectives™ on Stack Overflow

PHP if condition with strings

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related