onClick php PHP Function then redirect

Question

I have a page full of links that go to pdf's I want to track which links are being clicked. I thought I could do something like follows but am having issues:

<?
    function track($link)
    {
    $sql = "UPDATE database WHERE something = 'something';
    $db = new connection();
    $result = $db->query($sql);

    if($result){                 
                  header( 'Location: http://mywebsite/docs/. $link .' ) ;
                }
    }
?>

and my HTML would look like:

<a onClick="track(my_file_.pdf")">File Name</a>

Ok it looks like I am just going to use the link to pass the file name to a php script and once that is done I will redirect the user to the pdf.

bensiu · Accepted Answer · 2011-03-14 14:55:14Z

6

you are mixing JavaScript (client-site) with PHP (server-site) - will not work

It look like you want to count how many time pdfs are clicked (delivered) - consider other ways:

check access log and count
if your PDF is created by script - make update before created
execute AJAX request onclick which will update your database

edited Mar 14, 2011 at 14:55

answered Mar 14, 2011 at 14:48

bensiu

25.7k56 gold badges81 silver badges117 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MitMaro · Accepted Answer · 2011-03-14 14:54:12Z

3

As mentioned by others you are mixing client side code (the browser code) with the server side code (php). You need to change the html to be

<a href="redirector.php?file=my_file_.pdf">File Name</a>

You then need to create a php script to handle the request. For example redirector.php could look like this:

<?php
function track($link) {
    $sql = "UPDATE database WHERE something = 'something'";
    $db = new connection();
    $result = $db->query($sql);
    if ($result) {
        header('Location: http://mywebsite/docs/' . $link);
        exit;
    }
}

if (isset($_GET['file'])) {
     track($_GET['file']);
}

answered Mar 14, 2011 at 14:54

MitMaro

5,9876 gold badges31 silver badges52 bronze badges

Comments

Réjôme · Accepted Answer · 2011-03-14 14:48:02Z

2

Try using the href attribute instead of onClick() which is for javascript

answered Mar 14, 2011 at 14:48

Réjôme

1,4833 gold badges16 silver badges25 bronze badges

Comments

KJYe.Name · Accepted Answer · 2011-03-14 14:49:46Z

1

you are missing a double quote after 'something' you can't call php function like that after the page is rendered. Go with ajax or a GET/POST to your php script

answered Mar 14, 2011 at 14:49

KJYe.Name

17.2k5 gold badges51 silver badges63 bronze badges

Comments

saturngod · Accepted Answer · 2011-03-14 14:55:12Z

1

you should try with jquery ajax

<a onClick="track('my_file_.pdf')">File Name</a>


<script>
function track(link)
{
$.ajax({
  url: "update.php?link="+link,
  success: function(data){
    if(data=="DONE")
    {
        window.location="http://mywebsite/docs/"+link;
    }

  }
});
}
</script>

in update.php

<?php

$link=$_GET['link'];
 $sql = "UPDATE database WHERE something = 'something'";
    $db = new connection();
    $result = $db->query($sql);

    if($result){ 
        echo "DONE";
    }

?>

answered Mar 14, 2011 at 14:55

saturngod

25k18 gold badges65 silver badges87 bronze badges

Collectives™ on Stack Overflow

onClick php PHP Function then redirect

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related