Angular http get return undefined

Question

I have a express router get

var express = require('express');
var router = express.Router();
var mongoose = require('mongoose');
var Stats = require('../models/Stats.js');

/* GET ALL STATS */
router.get('/', function(req, res, next) {
  Stats.find(function (err, products) {
    if (err) return next(err);
    res.json(products);
  });
});

Also api

 getAll(){
    this.http.get('/main').subscribe(data => {
      console.log(data);
      return data;
    });
  }

And i am using it in component

show(){
      console.log(this.api.getAll());
   }

Problem is that when i log data in api getAll() data is returned well, but if i log data in component i have undefined.

mika · Accepted Answer · 2018-11-12 13:44:35Z

2

In getAll() you should return the observable:

getAll(){
   return this.http.get('/main');
}

And then in where you call the function you subscribe to the observable:

show(){
  this.api.getAll().subscribe((data) => {
       // Here you can do what you want with the data.
       console.log(data)
   })
}

edited Nov 12, 2018 at 13:44

answered Nov 12, 2018 at 13:38

mika

3431 silver badge14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mika · Accepted Answer · 2018-11-12 13:53:25Z

0

Your service or API within Angular should just be calling the backend service and not subscribing via in the service itself but rather in the component.

Service:

getAll(){
  return this.http.get('/main');
}

Component:

this.service.getAll().subscribe((data)=> {
   // Your Data
},error => {
   console.log('error: ', error)
});

edited Nov 12, 2018 at 13:53

mika

3431 silver badge14 bronze badges

answered Nov 12, 2018 at 13:49

Taranjit Kang

2,6103 gold badges24 silver badges41 bronze badges

Comments

SeleM · Accepted Answer · 2018-11-12 13:37:34Z

0

Your service should return, change your service to

getAll(){
    return this.http.get('/main').subscribe(data => {
      console.log(data);
      return data;
    });
  }

And it is better to subscribe in the component part not while declaring your services.

edited Nov 12, 2018 at 13:37

answered Nov 12, 2018 at 13:29

SeleM

9,6885 gold badges36 silver badges55 bronze badges

2 Comments

mika Over a year ago

Now the show() function is only going to log the observable returned by getAll().

SeleM Over a year ago

@mika what ?? you're wrong ! it is already subscribed there why would it return observable ??, reread what i'd written.

Collectives™ on Stack Overflow

Angular http get return undefined

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related