Decimal to Binary function, Python

Question

I am trying to created a function that takes in a Decimal represented value and converts it into Binary represented value.

Assuming the argument is always an integer:

import math

def binary_decimal_converter(x):

    binary_representation = 0
    number = x

    while number != 0:
        n = 1
        while x not in range(n,n*2):
            n *= 2
        binary_representation += 10**(int(math.log(n,2)))
        number -= n

    return binary_representation

The problem:

If x is in the list below, the program runs normally.

[1, 2, 4, 8, 16, 32, 64, 128....]

But if any other number is used, the program gets stuck in an unbreakable loop.

Why the loop:

while number != 0: #line 24

cannot run twice?

@QuangHoang supposedly, yes. The first time n = 2 and number -= 2. The second time n = 1 and number -= 1. Then number == 0 — SimpleAmature
– SimpleAmature, Commented Dec 17, 2018 at 19:17

Conner · Accepted Answer · 2018-12-17 19:13:19Z

1

You're assigning number = x and then using both:

import math

def binary_decimal_converter(x):
    binary_representation = 0
    number = x

    while number != 0:
        n = 1
        while x not in range(n,n*2): # CHANGE x TO number
            n *= 2
        binary_representation += 10**(int(math.log(n,2)))
        number -= n

    return binary_representation

If you change x to number on the specified line, it works. x is not being updated, number is.

answered Dec 17, 2018 at 19:13

Conner

31.4k8 gold badges55 silver badges75 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Decimal to Binary function, Python

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related