Quick Java SQL problem

Question

My code:

String sql = "SELECT Publisher.Name, Book.Title, ShopOrder.OrderDate, SUM(OrderLine.Quantity) AS No_Books, "
            + "SUM(OrderLine.UnitSellingPrice * Orderline.Quantity) AS Total_Price"
            + "FROM Publisher, Book, OrderLine, ShopOrder"
            + "WHERE OrderLine.BookID = Book.BookID AND ShopOrder.ShopOrderID = OrderLine.ShopOrderID AND Publisher.PublisherID = Book.PublisherID AND Publisher.PublisherID = " + id
            + "GROUP BY book.title, publisher.name, ShopOrder.OrderDate"
            + "ORDER BY ShopOrder.OrderDate, Book.Title";

Resulting error:

syntax error at or near "Publisher" at char position 166 (Just after the FROM clause)

Marcos Vasconcelos · Accepted Answer · 2011-03-30 21:26:02Z

5

Theres spaces missing

Your strings is ...S Total_PriceFROM Publisher, Book, OrderLine, ShopOrderWHERE O...

You should use:

String sql = "SELECT Publisher.Name, Book.Title, ShopOrder.OrderDate, SUM(OrderLine.Quantity) AS No_Books, "
        + " SUM(OrderLine.UnitSellingPrice * Orderline.Quantity) AS Total_Price"
        + " FROM Publisher, Book, OrderLine, ShopOrder"
        + " WHERE OrderLine.BookID = Book.BookID AND ShopOrder.ShopOrderID = OrderLine.ShopOrderID AND Publisher.PublisherID = Book.PublisherID AND Publisher.PublisherID = " + id
        + " GROUP BY book.title, publisher.name, ShopOrder.OrderDate"
            + " ORDER BY ShopOrder.OrderDate, Book.Title";

answered Mar 30, 2011 at 21:26

Marcos Vasconcelos

18.3k30 gold badges110 silver badges169 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jbasko · Accepted Answer · 2011-03-30 21:26:08Z

0

When you concatenate those strings there is no space between Total_Price and FROM. And in other lines similarly. I always end and start a quoted SQL fragment with a space.

answered Mar 30, 2011 at 21:26

jbasko

7,3503 gold badges42 silver badges52 bronze badges

Comments

Sean Adkinson · Accepted Answer · 2011-03-30 21:26:16Z

0

You need spaces either at the end of your lines or at the beginning. The resulting string would look like: ...AS Total_PriceFROM Publisher...

answered Mar 30, 2011 at 21:26

Sean Adkinson

8,6453 gold badges51 silver badges67 bronze badges

Collectives™ on Stack Overflow

Quick Java SQL problem

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related