Javascript: How to store a variable in a null variable in a constructor

Question

In the startGame()method, I am trying to store the selected phrase from the getRandomPhrase() method to the null property. It keeps throwing me an error saying

Game.activePhrase is null

What am I doing wrong?

Game.js:

class Game {

  constructor() {
    this.missed = 0;
    //directly put the phrases in the constructor
    this.phrases = [new Phrase("hello world"),
      new Phrase("Wolf on wall street"),
      new Phrase("Despite making"),
      new Phrase("Karen took the kids"),
      new Phrase("alright about to head out")
    ];
    this.activePhrase = null;
  }

  getRandomPhrase() {
    //returns 5 of the random phrases
    return this.phrases[Math.floor(Math.random() * this.phrases.length)];
  }

  startGame() {
    let hid = document.getElementById('overlay');
    hid.style.display = "none";
    let phrs = this.getRandomPhrase();
    phrs.addPhraseToDisplay();
    return this.activePhrase(phrs); //trying to store it by doing this
  }
}

App.js

const game = new Game();
game.startGame();
console.log(`Active Phrase - phrase: ${game.activePhrase.phrase}`);

this.activePhrase = phrs; ?

Jonas Wilms
– Jonas Wilms

2019-03-13 07:01:18 +00:00
Commented Mar 13, 2019 at 7:01 — Jonas Wilms
– Jonas Wilms, Commented Mar 13, 2019 at 7:01

Prasad Telkikar · Accepted Answer · 2019-03-13 07:01:01Z

1

Assign value to activePhase variable before returning it from startGame method

this.activePhrase = phrs;

Like

  startGame() {
    let hid = document.getElementById('overlay');
    hid.style.display = "none";
    let phrs = this.getRandomPhrase();
    phrs.addPhraseToDisplay();
    this.activePhrase = phrs; //Key to fix your issue
    return this.activePhrase;
  }

answered Mar 13, 2019 at 7:01

Prasad Telkikar

16.1k7 gold badges26 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Snow · Accepted Answer · 2019-03-13 07:00:12Z

0

You never assigned to .activePhrase (you tried to call .activePhrase as if it was a function, but it's not). Try assigning phrs to this.activePhrase instead:

this.activePhrase = phrs;

answered Mar 13, 2019 at 7:00

Snow

4,1463 gold badges16 silver badges43 bronze badges

Comments

Jack Bashford · Accepted Answer · 2019-03-13 07:04:51Z

0

this.activePhrase is not a functoin - therefore this.activePhrase(phrs) will not do anything. Simply assign the value:

this.activePhrase = phrs;

answered Mar 13, 2019 at 7:04

Jack Bashford

44.3k11 gold badges56 silver badges84 bronze badges

Collectives™ on Stack Overflow

Javascript: How to store a variable in a null variable in a constructor

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related