Python class variable accessed by multiple instances

Question

I want to define a global variable which can be accessed (read and write) by all instances of the class. My current solution is shown in the example below. I don't like having a variable in the global namespace, but I was not able to put idx in class. How can I put idx in class and achieve the same?

# working
idx = 0
class test(object):
    def add(self):
        global idx
        idx += 1
    def print_x(self):
        global idx
        print(idx)

test1 = test()
test1.add()
test1.print_x()
test2 = test()
test2.add()
test2.print_x()

# Error
class test(object):
    idx = 0
    def add(self):
        global idx
        idx += 1
    def print_x(self):
        global idx
        print(idx)

test1 = test()
test1.add()
test1.print_x()
test2 = test()
test2.add()
test2.print_x()

Traceback (most recent call last):
  File "test.py", line 16, in <module>
    test1.add()
  File "test.py", line 9, in add
    idx += 1
NameError: global name 'idx' is not defined

I think you want a @classmethod (though I'm out of my depth here). — wjandrea
– wjandrea, Commented May 13, 2019 at 20:30
What do you mean by "keep track" exactly? I don't understand your goal here. — Valentino
– Valentino, Commented May 13, 2019 at 20:32
If you search on the phrase "Python class variable", you’ll find resources that can explain it much better than we can in an answer here. You have the correct term, but what you've implemented is a common global variable. — Prune
– Prune, Commented May 13, 2019 at 20:32
What you show under # Error should be fine, so it's not clear what is not working for you. Can you post a complete (short, presumably) program that fails, with the exact error? — zdim
– zdim, Commented May 13, 2019 at 20:33

Prune · Accepted Answer · 2019-05-13 20:35:46Z

4

Your code fails because you tried to access a global variable idx without properly declaring it. You need to access your class variable.

class Test(object):
    idx = 0
    def add(self):
        Test.idx += 1

obj = Test()
obj.add()
print(Test.idx)
obj = Test()
obj.add()
print(Test.idx)

Output:

1
2

answered May 13, 2019 at 20:35

Prune

78k14 gold badges63 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

SyntaxVoid · Accepted Answer · 2019-05-13 22:08:46Z

2

Here's a hacky little way that doesn't need any global variables. It makes use of the fact that default arguments are only created once when __init__ is called for the first time and if the default arguments are mutable, then changing one of them will impact all future functions/instances of the same class.

We can create idx as a list since lists are mutable and then make sure we only modify that list in place. Doing so like this will ensure that all instances of your Test class point to the exact same idx list. Changing one changes them all, so long as you only do in-place modifications.

class Test:
    def __init__(self, idx = [0]):
        self.idx = idx

    def add(self):
        self.idx[0] += 1

a = Test()
b = Test()

a.add()

print(a.idx, b.idx)
# >> Prints [1], [1]

edited May 13, 2019 at 22:08

answered May 13, 2019 at 20:37

SyntaxVoid

2,6413 gold badges17 silver badges24 bronze badges

1 Comment

mbhargav294 Over a year ago

Array passed as default argument is created only on the first call to init. Very hacky but brilliant.

mbhargav294 · Accepted Answer · 2019-05-13 20:47:12Z

You can achieve this using a singleton pattern. Here is a small example with singleton:

class Singleton:
    # Here will be the instance stored.
    __instance = None

    @staticmethod
    def getInstance():
        """ Static access method. """
        if Singleton.__instance == None:
            Singleton()
        return Singleton.__instance

    def add(self):
        self.idx += 1

    def __init__(self):
        """ Virtually private constructor. """
        if Singleton.__instance != None:
            raise Exception("This class is a singleton!")
        else:
            Singleton.__instance = self
            self.idx = 0

In [3]: main = Singleton()
In [4]: a = Singleton.getInstance()
In [5]: print(a.idx)
0

In [6]: a.add()
In [7]: print(a.idx)
1

In [8]: b = Singleton.getInstance()
In [9]: print(b.idx)
1

Ref: https://www.tutorialspoint.com/python_design_patterns/python_design_patterns_singleton.htm

There are some elegant Singleton examples on SO as well.

Norbert Incze · Accepted Answer · 2019-05-13 21:05:42Z

You have to define your variable in the class, outside of methods, and it shall not be a self variable. A self variable is unique to every instances. In methods you have to use the class name for accessing the variable, otherwise the method will look at it as a private variable, and in most cases you will get an error, because it was not initialized before usage.

class MyClass:
    my_public_variable = 0
    __my_private_variable = 5

    def inc(self):
        MyClass.my_public_variable += 1
        MyClass.__my_private_variable += 1

    def show(self):
        print(MyClass.my_public_variable)
        print(MyClass.__my_private_variable)

obj1 = MyClass()
obj1.show()

obj2 = MyClass()
obj2.show()

obj1.inc()
obj2.show()

print(obj1.my_public_variable)
print(obj1.my_private_variable) # Invokes error

By running this code, the following will be printed out without the parenthesis:

0  (my_public_variable of obj1)
5  (my_private_variable of obj1)
0  (my_public_variable of obj2)
5  (my_private_variable of obj2)
1  (my_public_variable of obj2, incremented by obj1)
6  (my_private_variable of obj2, incremented by obj1)
1  (my_public_variable of obj1, it can be accessed outside of the class, since it is a public variable of the class)
Error (because, as its name suggests, my_private_variable is a private variable of the class)

Collectives™ on Stack Overflow

Python class variable accessed by multiple instances

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related