PHP FOREACH ARRAY problem

Question

This is what I have:

$prevtag = "1,2,5";

$arr;
$arr["1"] = "BOOKS";
$arr["2"] = "MAGAZINES";
$arr["3"] = "PAMPHLETS";
$arr["4"] = "CD'S";
$arr["5"] = "DVD'S";

And I need to check if any of $prevtag exists in $arr and then echo 5 checkboxes:

foreach ($arr as $key => $value) {
    $checked = in_array($prevtag,$arr) ? '' : 'checked="checked"';
    echo "<input name=\"txtTags".$key."\" type=\"checkbox\" id=\"txtTags".$key."\" value=\"on\" $checked />\n";
    echo "<label for=\"txtTags".$key."\">".$value."</label>\n";
}

But I'm getting all checked and not just the ones in $prevtag - What am I doing wrong?

Treffynnon · Accepted Answer · 2011-04-13 11:42:09Z

2

In your example $prevtag is a string and not an array so you cannot use in_array() on it.

So you can try:

$prevtag = explode(',', $prevtag);

And then:

foreach ($arr as $key => $value) {
    $checked = in_array($key, $prevtag) ? '' : 'checked="checked"';
    echo "<input name=\"txtTags".$key."\" type=\"checkbox\" id=\"txtTags".$key."\" value=\"on\" $checked />\n";
    echo "<label for=\"txtTags".$key."\">".$value."</label>\n";
}

answered Apr 13, 2011 at 11:42

Treffynnon

21.6k6 gold badges68 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shakti Singh · Accepted Answer · 2011-04-13 11:43:26Z

1

Make $prevtag an array and do something like this

$preArray=explode(",",$prevtag);

foreach ($arr as $key => $value) {
    $checked = in_array($key,$preArray) ? 'checked="checked"' : '';
    ...
}

answered Apr 13, 2011 at 11:43

Shakti Singh

86.7k21 gold badges142 silver badges156 bronze badges

Comments

bensiu · Accepted Answer · 2011-04-13 11:46:24Z

1

$checked = strpos( $prevtag, (string)$key ) ? '' : 'checked="checked"';

$prevtag is string not array -> in_array() would not apply

edited Apr 13, 2011 at 11:46

answered Apr 13, 2011 at 11:41

bensiu

25.7k56 gold badges81 silver badges117 bronze badges

Comments

Teneff · Accepted Answer · 2011-04-13 11:44:45Z

0

in_array($prevtag,$arr) is checking if the array $arr contains value 1,2,5

so you can do this:

$checked = in_array($key, explode(',', $prevtag)) ? '' : 'checked="checked"';

answered Apr 13, 2011 at 11:44

Teneff

32.3k13 gold badges76 silver badges107 bronze badges

Comments

Bruce Aldridge · Accepted Answer · 2011-04-13 11:42:42Z

0

you are checking if '1,2,5' is inside 'books' or 'magazines' etc

$prevtag = array(1,2,5);
$checked = in_array($key, $prevtag) ? 'checked="checked"' : ''

answered Apr 13, 2011 at 11:42

Bruce Aldridge

2,9374 gold badges23 silver badges31 bronze badges

Collectives™ on Stack Overflow

PHP FOREACH ARRAY problem

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related