javaScript jQuery function, how do i pass variables

Question

What is wrong with my code. How do i pass attrfull to the inside. The way i have it done, if i run the function editsubmit($selected, size), $selected is inserted properly but i'm getting attrfull instead of size.

function editsubmit(attr, attrfull) {
    if (attr.length) {
        attr.val().length ? $selectedinput.attr({
            attrfull: attr.val()
        }) : $selectedinput.removeAttr(attrfull);
    }
}

$selected is a variable and attrfull i a string. Do i need double qoutes around the string when i run the function like editsubmit($selected,'size').

Just a thought, but try this: attr(attrfull, attr.val()). Should work... — Khez
– Khez, Commented Apr 13, 2011 at 21:31
Yes, single quotes or double quotes around the literal strings. — amit_g
– amit_g, Commented Apr 13, 2011 at 21:32
I think you should post the code that creates your editsubmit call. It looks like you're using PHP to generate the JS call...which is fine...but we need to see how you construct the edit submit call. — dmcnelis
– dmcnelis, Commented Apr 13, 2011 at 21:33
attr.val() is the not the issue and i'm not using any php. This is a simple function. The only problem i'm having is attrfull is not being passed in to the attrfull that i have inside the function. So if i have editsubmit($var, 'size'), i'm expecting every reference to attrfull inside the function to be replaced with size. But this is not happening. — Pinkie
– Pinkie, Commented Apr 13, 2011 at 21:38

Hussein · Accepted Answer · 2011-04-13 21:44:35Z

2

Try

function editsubmit(attr, attrfull) {
    if (attr.length) {
        attr.val().length ? $selectedinput.attr(attrfull, attr.val()) : $selectedinput.removeAttr(attrfull);
    }
}

answered Apr 13, 2011 at 21:44

Hussein

42.9k25 gold badges115 silver badges143 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

typeof · Accepted Answer · 2011-04-13 21:33:20Z

1

Yes, you do need it to be a string (in double quotes), or else it will think you're trying to pass a variable reference.

answered Apr 13, 2011 at 21:33

typeof

5,9722 gold badges18 silver badges19 bronze badges

Comments

James · Accepted Answer · 2011-04-13 21:43:56Z

1

The problem is this: {attrfull: attr.val()}

I think you want it to be {size: (whatever attr.val() is)}

So:

function editsubmit(attr, attrfull) {
    if (attr.length) {
        if (attr.val().length) {
          var myObj = {};
          myObj[attrfull] = attr.val();
          $selectedinput.attr(myObj);
        } else {
          $selectedinput.removeAttr(attrfull);
        }
    }
}

answered Apr 13, 2011 at 21:43

James

22.4k5 gold badges29 silver badges44 bronze badges

Collectives™ on Stack Overflow

javaScript jQuery function, how do i pass variables

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related