Need to execute a sql query with variables from a foreach loop

Question

So I need to run my sql query in a foreach loop, but, say there are two variables in the foreach loop, the query only executes the iteration with the first variable twice, instead of executing both the first and the second variable.

My code

$sql = "SELECT * FROM users WHERE idUsers = '$selected';";

$result = mysqli_query($conn, $sql);
if($row = mysqli_fetch_assoc($result))
{
    foreach($_POST['order-check'] as $check) 
    {
        $sql2 = "UPDATE order_table SET order_status = 'Processing', assigned_vendor = '$selectedvendor' WHERE order_id = '$check';";
        $result2 = mysqli_query($conn, $sql2);
        exit();
    }
}
else{
    echo "failed";
    exit();
}

Here, $selected is a POST variable from another page

You have exit() in there, so it will only run the loop once. You also only fetch one row in your select query, while you loop the $_POST['order-check'] until the end (except you exit after the first iteration). — Qirel
– Qirel, Commented Jul 11, 2019 at 6:41
Your second query doesn't use anything from $row. Why are you doing it in the loop? — Barmar
– Barmar, Commented Jul 11, 2019 at 6:49
Never mind, I thought you were doing while ($row = mysqli_fetch_assoc($result)). — Barmar
– Barmar, Commented Jul 11, 2019 at 6:54

Stevo S · Accepted Answer · 2019-07-11 06:48:16Z

1

As Qirel mentioned, remove the "exit()" from your foreach statement. Also, please ensure you sanitize any POST or GET variables before inserting into the database :)

Your statement should look like this if you want to loop through all $_POST variables

  foreach($_POST['order-check'] as $check) 
        {
            $sql2 = "UPDATE order_table SET order_status = 'Processing', assigned_vendor = '$selectedvendor' WHERE order_id = '$check';";
            $result2 = mysqli_query($conn, $sql2);
            //exit();
        }

answered Jul 11, 2019 at 6:48

Stevo S

132 silver badges4 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Need to execute a sql query with variables from a foreach loop

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related