Segmentation fault c++ with strings array

Question

When I run my program, I get the Segmentation Fault error. I believe it is coming from how I am using the array "string *words" which is privately declared in the class definition. I use it here in the .cpp file anyone know what I need to change? heres the function I think the problem is in:

Dictionary::Dictionary(string filename){

    ifstream inF;

    inF.open(filename.c_str());

    if (inF.fail()){
      cerr << "Error opening file" <<endl;
      exit(1);
    }

    inF >> numwords;
    numwords = 3000;
    words = new string(words[numwords]);


    for(int i=0; i <= numwords - 1; i++){
      inF >> words[i];
    }
    inF.close();
  }

words = new string(words[numwords]) - what is that line supposed to do in your code? What is the purpose of words[numwords] on the right-hand side, inside the braces? If you are the author, then I'm sure you should be able to explain why it is written that way. — AnT stands with Russia
– AnT stands with Russia, Commented Apr 19, 2011 at 0:25
What are you implying Andrey? It may just be a simple mistake. — user431528
– user431528, Commented Apr 19, 2011 at 1:04

yan · Accepted Answer · 2011-04-19 00:18:39Z

9

The line:

words = new string(words[numwords]);

should actually be:

words = new string[numwords];

answered Apr 19, 2011 at 0:18

yan

21k3 gold badges41 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Greg Hewgill · Accepted Answer · 2011-04-19 00:19:08Z

4

You are going to need to learn how to use a debugger. The exact procedure depends on what system you're using. But if you run your code in a debugger, the debugger will stop on the exact line where the problem was detected. As you can imagine, this is very helpful for debugging.

Note that the line where the problem was detected and the line where the problem started may be quite different.

answered Apr 19, 2011 at 0:19

Greg Hewgill

1.0m192 gold badges1.2k silver badges1.3k bronze badges

Collectives™ on Stack Overflow

Segmentation fault c++ with strings array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related