remove an object from mongodb array of objects

Question

I have a problem with removing an object in mongoose. I have the schema

shareholder.model.js

const Shareholder = mongoose.Schema({
    name: String,
    shares: [
        {
            type: mongoose.Schema.Types.Mixed, ref: 'shares' 
        }
    ],
})

mongoose.model('Shareholder', Shareholder)

So I'm trying to remove an object from 'shares' field

shareholder.service.js

// {shareholderId} id of object
// {shareId} unique id which have every object of the array

async function removeShareFromShareholder(shareholderId, shareId) {
try {
   await Shareholder.findByIdAndUpdate(shareholderId, 
                { $pull : { 'shares' : { '_id' : shareId } }},
                { safe: true })
    }
} catch (error) {
   throw new Error(`removeShareFromShareholder service error: ${error}`)
    }
}

But code above doesn't work

Can you give me an advice

Asaf Aviv · Accepted Answer · 2019-08-06 12:42:28Z

1

Since you are saving ObjectId refs, you should change the type of shares to Schema.Types.ObjectId

then since the array contains only ids and not a document with the _id property change

{ $pull : { 'shares' : { '_id' : shareId } }}

to

{ $pull : { shares : shareId }}

answered Aug 6, 2019 at 12:42

Asaf Aviv

11.8k2 gold badges33 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mara1esh Over a year ago

You're awesome! Thanks

Collectives™ on Stack Overflow

remove an object from mongodb array of objects

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related