Php database models

Question

<?php
 class ann {

      public function __construct($context, $orgs_id, $created_at) {
         $this->context = $context;
         $this->orgs_id = $orgs_id;
         $this->created_at = $created_at;
     }

     function create(){
         $createann = mysql_query("INSERT INTO anns(context,
 orgs_id, created_at)
 VALUES('$this->context',
 $this->orgs_id, '$this->created_at'");
         if($createann) echo "Duyuru Başarıyla Eklendi"; else echo "Duyuru
 Eklenemedi";
     }
     function read($id){
         $readann = mysql_query("SELECT * FROM anns WHERE id = $id");
         $context = mysql_result($readann,0, "context");
         $orgs_id = mysql_result($readann,0, "orgs_id");
         $created_at = mysql_result($readann,0,
 "created_at");

         $ann = new ann($context, $orgs_id, $created_at);

         return $ann;
     }
     function update($id, $context){
         $updateann = mysql_query("UPDATE anns SET context =
 '$context' WHERE id = $id");
         if($updateann) echo "Update success"; else echo
 "Update failed";
     }
     function delete($id){
         $deleteann = mysql_query("DELETE FROM anns WHERE id
 = $id");
         if($deleteann) echo "Delete success"; else echo "Delete not success";
     }
     //crud fonksiyonlari burda bitiyor 
}

?>

There is something wrong with our logic here but we are very new to php. We tried to create rails like models, but it think something with our class-object notation is wrong. So the code did not work. We cannot even create any object with it. Thank you guys

Your code's comment at the bottom removes the closing } for the class. Is this mistake just in the post? — walkingTarget
– walkingTarget, Commented Apr 21, 2011 at 14:16
yes it was just a mistake in the post, thanks for pointing out — gkaykck
– gkaykck, Commented Apr 21, 2011 at 14:19
thanks injection warnings but we are using a filter before the strings arrive to object creation. — gkaykck
– gkaykck, Commented Apr 21, 2011 at 14:53

mario · Accepted Answer · 2011-04-21 18:50:29Z

1

context, orgs_id and created_at ~~must be~~ should be first declared either as public, private or protected before you use them.

In your create method, you don't filter user input. This may cause to your application SQL injection, you have to you always filter user input. Use either mysql_real_escape_string or prepared statment by PDO.

You may check this tutorial.

edited Apr 21, 2011 at 18:50

mario

146k20 gold badges243 silver badges293 bronze badges

answered Apr 21, 2011 at 14:31

SIFE

5,7537 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

crono · Accepted Answer · 2011-04-21 14:17:54Z

0

two things (which maybe only apply to your codesample here):

In your sample, you dont close your Class, because the last "}" is commented out.
You never opened a connection to your database, so the query would fail.

answered Apr 21, 2011 at 14:17

crono

3,6833 gold badges29 silver badges24 bronze badges

Comments

pleasedontbelong · Accepted Answer · 2011-04-21 14:22:25Z

0

a few observations:

declaring the attributes in the constructor is possible, but it's not elegant. I'd rather do:

class ann {
  private $context;
  private $orgs_id;

the "->" operator won't work inside a string. You'll need to concatenate the query:

"INSERT INTO anns(context,orgs_id, created_at) VALUES('".$this->context."',".$this->orgs_id".", '".$this->created_at."'"

but be careful on sql injection

The rest should be fine! Good Luck.

answered Apr 21, 2011 at 14:22

pleasedontbelong

20.1k12 gold badges55 silver badges79 bronze badges

2 Comments

Neil Aitken Over a year ago

You can use object operators inside strings if you wrap them in {} e.g "Property value is {$object->property}";

Capsule Over a year ago

There's also a very good tutorial about good PHP OOP practices here: phpfreaks.com/tutorial/oo-php-part-2-boring-oo-principles

Collectives™ on Stack Overflow

Php database models

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related