How to use AngularJS $q deferred promises to return data from an async function?

Question

I am having some troubles implementing AngularJS $q to get data from an async function and use it in an outer scope. Basically, I want to make the last line work in the below code. I have seen some examples but can't seem to wrap my head around AngularJS $q implementation.

var app = angular.module("myShoppingList", []);
        app.controller("myCtrl", function ($scope, $q) {

            const Papa = require('papaparse'); //I know these won't work, just added to give context
            const AWS = require('aws-sdk')

            AWS.config.update({
                //keys go here
            })

            const s3 = new AWS.S3()


            /* actual parameters should go here */
            const params = {
                Bucket: "test-bucket-2019",
                Key: "dummy.csv"
            };

            const parseOptions = {
                header: true,
                dynamicTyping: true /* will assume numbers are actually numbers, yada yada */
            }

        let deferred = this.$q.defer(); //how to use this???


            function getS3Data() {
                s3.getObject(params, function (err, data) {
                    if (err) console.log(err, err.stack);
                    else {
                        const csv = data.Body.toString('utf-8');
                        const headers = 'id,start,end,count';
                        const parsed = Papa.parse(headers + '\n' + csv, parseOptions);
                        var parsedData = parsed.data;
                        console.log(parsedData); //this works
                    }
                    return parsedData;

                })


            }
          console.log(parsedData) //how to make this work

        });

Venkatesh Chitluri · Accepted Answer · 2019-10-18 16:19:27Z

1

One small edit required for the above answer, the return statement should be at the end of the function.

  function getS3Data() {
  let deferred = $q.defer(); 
  s3.getObject(params, function (err, data) {
    if (err) { 
      //console.log(err, err.stack);
      deferred.reject(err);
    }
    else {
      const csv = data.Body.toString('utf-8');
      const headers = 'id,start,end,count';
      const parsed = Papa.parse(headers + '\n' + csv, parseOptions);
      var parsedData = parsed.data;
      console.log(parsedData); //this works

      //return parsedData;  // do not return data
      deferred.resolve(parsedData);  // resolve the deferred with the data
    }
  });
 return deferred.promise;  // important! return the promise, NOT THE DATA
}

answered Oct 18, 2019 at 16:19

Venkatesh Chitluri

1347 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pop-A-Stash · Accepted Answer · 2019-10-18 18:36:24Z

0

Deferred is used to turn a callback function into a promise function.

function getS3Data() {
  let deferred = $q.defer(); 
  s3.getObject(params, function (err, data) {
    if (err) { 
      //console.log(err, err.stack);
      deferred.reject(err);
    }
    else {
      const csv = data.Body.toString('utf-8');
      const headers = 'id,start,end,count';
      const parsed = Papa.parse(headers + '\n' + csv, parseOptions);
      var parsedData = parsed.data;
      console.log(parsedData); //this works

      //return parsedData;  // do not return data
      deferred.resolve(parsedData);  // resolve the deferred with the data
    } 

  });
  return deferred.promise;  // important! return the promise, NOT THE DATA
}

When you call the function, you must define .then()/.catch() functions:

getS3Data().then(function(parsedData) {
   console.log(parsedData);
}).catch(function(err) {
  console.log(err, err.stack);
});

edited Oct 18, 2019 at 18:36

answered Oct 18, 2019 at 13:58

Pop-A-Stash

6,6975 gold badges30 silver badges54 bronze badges

1 Comment

azrael v Over a year ago

Hi, I am getting .then is not a function error in this.

Collectives™ on Stack Overflow

How to use AngularJS $q deferred promises to return data from an async function?

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related