Data from viewmodel doesn't go into database C# MVC

Question

The model in the parameter has values all the way to the DAL method where the query is but somehow nothing changes in the database. Anyone got any clue why? Also no errors occurred. Controller:

public ActionResult AddCar(CarModel car)
{
        if(ModelState.IsValid)
        {
            u.AddCar(new DTO.CarDTO(car.Color, car.Type, car.NumberOfSeats, car.Price, car.MaxKilometres, car.Addition, car.ModelID, car.License_Plate, car.Fueltype, car.ReservationStatus));
            return RedirectToAction("Index", "Home");
        }
        return View();
}

Logic:

public void AddCar(CarDTO c)
{
    carDAL.AddCar(new CarDTO(c.Color, c.Type, c.NumberOfSeats, c.Price, c.MaxKilometres, c.Addition, c.ModelID, c.License_Plate, c.Fueltype, c.ReservationStatus));
}

Interface layer:

public interface ICarDAL<CarDTO>
{
    public void AddCar(CarDTO c) { }
}

DAL, class does have connectionstring:

public void AddCar(CarDTO c)
{
    using (SqlConnection con = new SqlConnection(connectionString))
    {
        string query = "INSERT INTO [dbo].[Car](Price, Addition, License_Plate, MaxKm, Type, Color, NumberOfSeats, Fueltype, reservationStatus, ModelID) " +
            "VALUES(@Price, @Addition, '@LicensePlate', @MaxKm, '@Type', '@Color', @NumberOfSeats, @FuelType, @Reserved, @ModelID)";

        using (SqlCommand cmd = new SqlCommand(query, con))
        {
            cmd.Parameters.AddWithValue("@Price", c.Price);
            cmd.Parameters.AddWithValue("@Addition", c.Addition);
            cmd.Parameters.AddWithValue("@LicensePlate", c.License_Plate);
            cmd.Parameters.AddWithValue("@MaxKm", c.MaxKilometres);
            cmd.Parameters.AddWithValue("@Type", c.Type);
            cmd.Parameters.AddWithValue("@Color", c.Color);
            cmd.Parameters.AddWithValue("@NumberOfSeats", c.NumberOfSeats);
            cmd.Parameters.AddWithValue("@FuelType", c.Fueltype);
            cmd.Parameters.AddWithValue("@ReservationStatus", c.ReservationStatus);
            cmd.Parameters.AddWithValue("@ModelID", c.ModelID);
        }
    }
}

Found the error but I still dont know how to fix it: https://i.sstatic.net/Stdh5.jpg

Solution: First of all I needed to use ExecuteNonQuery() to make the query actually do something...I thought SqlCommand already executed it for you. Secondly my password consisted out of ************ which I thought it wouldn't matter but I guess it did.

You're not executing the command. So cmd.ExecuteNonQuery(); after assigning your params would work. Also on another note use Add and specify the data type not AddWithValue as the values would be inferred and may not be what you need. — Trevor
– Trevor, Commented Nov 10, 2019 at 17:31
@Çöđěxěŕ So I put that code in the cmd using, so right under the last cmd.Parameters.AddWithValue();. But now I get 'ExecuteNonQuery requires an open and available Connection. The connection's current state is closed.' — zhrgci
– zhrgci, Commented Nov 10, 2019 at 18:00
P.s. ADO.NET is one of the ways you can connect to a database from .NET programs. So you can use it as part of an asp.net application, or part of a desktop app or console app, or whatever. — ADyson
– ADyson, Commented Nov 10, 2019 at 21:14
No. That's completely irrelevant. Did you try googling your error message? There are several previous questions on this site about that error, as well as on other sites. For example this one or this one and several others all have a lot of useful suggestions which might be relevant to your situation. Please do some searching and try out the possible solutions. — ADyson
– ADyson, Commented Nov 11, 2019 at 9:38
@ADyson I sincerely thank you for helping me. I didn't know the query wouldn't execute if I didn't use ExecuteNonQuery(). Also the problem was that my password consisted of only ********* instead of the actual password, but thanks for helping :D — zhrgci
– zhrgci, Commented Nov 11, 2019 at 10:06

erdi yılmaz · Accepted Answer · 2019-11-11 05:09:56Z

1

public void AddCar(CarDTO c)
{
    using (SqlConnection con = new SqlConnection(connectionString))
    {
        if (con.State==ConnectionState.Closed)
            {                      
                con.Open();   
             }
         [Your code]
         con.Close();
    }
 }

answered Nov 11, 2019 at 5:09

erdi yılmaz

3481 gold badge4 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

zhrgci Over a year ago

It says "SqlException: Login failed for user 'mydatabase'"

erdi yılmaz Over a year ago

Check your connectionstring is true.

erdi yılmaz Over a year ago

and check your user can access your database

cklimowski · Accepted Answer · 2019-11-11 17:48:14Z

-2

You may need to use a "save" function, I'm not seeing anywhere in your code where the SQL command is actually executed, I see it being built, but I've used it in the past with something similar like cmd.Execute()

edited Nov 11, 2019 at 17:48

answered Nov 10, 2019 at 17:25

cklimowski

5667 silver badges22 bronze badges

4 Comments

zhrgci Over a year ago

I didn't downvote anything so i dont know. Sorry how can you see if you use entity framework or not?

zhrgci Over a year ago

So what you're saying is using (SqlCommand cmd = new SqlCommand(query, con)) isn't going to execute the query? I thought it would...

ADyson Over a year ago

Don't know about anyone else but I downvoted this because it's self-evident from the code shown that it isn't using entity framework

cklimowski Over a year ago

Thanks for letting me know, I edited my response. I think my answer is applicable, the actual SQL command is not being executed without the Execute function.

Collectives™ on Stack Overflow

Data from viewmodel doesn't go into database C# MVC

2 Answers 2

3 Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related