Query get api with array

Question

I need to fetch information and bring it into an array, but errors are occurring.

Below the code of the class that makes the get query

public function getByLoja(string $uuid): array
{
    $query = HorarioLoja::all();

    $query = $query->where('loja', function ($loja) use ($uuid) {
        $loja->where('uuid', $uuid);
    });

    $horariosDaLoja = $query->get();

    $saida = [];
    foreach ($horariosDaLoja as $horario) {
        $saida[] = $this->horarioLojaTransformador->paraModelo($horario);
    }

    return $saida;
}

Below the model code

class HorarioLoja extends Model
{
    protected $dates = ['created_at', 'updated_at'];
    protected $table = 'horario_lojas';

    public function loja()
    {
        return $this->belongsTo(Loja::class, 'loja_id', 'id');
    }
}

Error:

Too few arguments to function Illuminate\Support\Collection::get(), 0 passed in /var/www/html/code/app/Persistencia/Laravel/Repositorios/HorariosLojasRepositorioLaravel.php on line 32 and at least 1 expected {"exception":"[object] (Symfony\Component\Debug\Exception\FatalThrowableError(code: 0): Too few arguments to function Illuminate\Support\Collection::get(), 0 passed in /var/www/html/code/app/Persistencia/Laravel/Repositorios/HorariosLojasRepositorioLaravel.php on line 32 and at least 1 expected at /var/www/html/code/vendor/laravel/framework/src/Illuminate/Support/Collection.php:874)

Rwd · Accepted Answer · 2019-12-04 16:26:21Z

1

When you use all() with an Eloquent model you're actually executing the query.

You can simply remove the call to all() and have:

public function getByLoja(string $uuid): array
{
    $horariosDaLoja = HorarioLoja::whereHas('loja', function ($loja) use ($uuid) {
        $loja->where('uuid', $uuid);
    })->get();

    $saida = [];
    foreach ($horariosDaLoja as $horario) {
        $saida[] = $this->horarioLojaTransformador->paraModelo($horario);
    }

    return $saida;
}

Since using get() with Eloquent will return a collection you could even do something like:

public function getByLoja(string $uuid): array
{
    return HorarioLoja::whereHas('loja', function ($loja) use ($uuid) {
            $loja->where('uuid', $uuid);
        })
        ->get()
        ->map(function ($horario) {
            return $this->horarioLojaTransformador->paraModelo($horario);
        })
        ->toArray();
}

edited Dec 4, 2019 at 16:26

answered Dec 4, 2019 at 14:54

Rwd

35.3k7 gold badges71 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Richard Nicson Over a year ago

column error is occurring, I believe the correct would not be where but wherehas.

Rwd Over a year ago

@RichardNicson Sorry, I didn't even notice that, I'd just copied and pasted the code from your question...my bad. Have you tried the code with whereHas and did it work?

Rwd Over a year ago

@RichardNicson What's the error you're getting now?

Richard Nicson Over a year ago

"mensagem": "Undefined variable: horario",

Rwd Over a year ago

@RichardNicson If you're going off the second example, I've just updated it. I'd forgotten to replace $item with $horario.

Patryk · Accepted Answer · 2019-12-04 14:43:56Z

0

method get for collection need a value, check doc :Collection-Get

so you don't need this ->

$horariosDaLoja = $query->get();

becouse here

       $query = HorarioLoja::all();
       $query = $query->where('loja', function($loja) use ($uuid) {
            $loja->where('uuid', $uuid);
        });

you have your records in $query and you can use ->toArray method for collection, check toArray

           $query = $query->where('loja', function($loja) use ($uuid) {
            $loja->where('uuid', $uuid);
        })->toArray();

answered Dec 4, 2019 at 14:43

Patryk

754 bronze badges

Collectives™ on Stack Overflow

Query get api with array

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related