PHP OOP - Wrong object returned

Question

with the follow code:

<?php
class Loader {
    private static $instances;

    function __construct($class = null) {
        return self::instance($class);
    }

    public static function instance($class) {
        if(!isset(self::$instances[$class])) {
            self::$instances[$class] = new $class();
        }

        return self::$instances[$class];
    }
}

class Core {
}

$core = new Loader('Core');
print_r($core);

?>

my print_r() return the object Loader instead the object Core, which is instantiated after Loader is constructed.

Thanks for help!

bobflux · Accepted Answer · 2011-05-08 22:11:27Z

8

Hm ?

If you do

$core = new Loader('Core');

Then $core is going to be an instance of Loader... PS : constructors don't return a value.

You don't need to instantiate Loader at all.

Do this :

<?php
class Loader {
    private static $instances;

    public static function instance($class) {
        if(!isset(self::$instances[$class])) {
            self::$instances[$class] = new $class();
        }

        return self::$instances[$class];
    }
}

class Core {
}

$core = Loader::instance('Core');
print_r($core);

Or you could do a much simpler :

<?php
function Load($class)
{
    static $instances;
    if(!isset($instances[$class]))
         $instances[$class] = new $class();
    return $instances[$class];
}

class Core {
}

$core = Load('Core');
print_r($core);

edited May 8, 2011 at 22:11

answered May 8, 2011 at 21:28

bobflux

11.6k3 gold badges31 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Maerlyn Over a year ago

There's a mistake in the function example: you call it Loader, but later call it as Load.

Gabriel Santos Over a year ago

Thanks, I thought I could not set static variables within functions.

Collectives™ on Stack Overflow

PHP OOP - Wrong object returned

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related