jQuery/javascript basic logic question

Question

I am using a jQuery method $.getJSON to update data in some cascading drop down lists, in particular, a default value if there is nothing returned for the drop down, e.g. "NONE".

I just want some clarification to how my logic should go.

var hasItems = false; 
$.getJSON('ajax/test.json', function(data) {
hasItems = true;

    //Remove all items
    //Fill drop down with data from JSON


});

if (!hasItems)
{
    //Remove all items
    //Fill drop down with default value
}

But I don't think this is right. So do I enter into the function whether or not I receive data? I guess I really want to check the data object contains something - to set my boolean hasItems.

J.W. · Accepted Answer · 2011-05-13 01:27:37Z

6

You should handle the check right inside the callback function, check the example here.

var hasItems = false; 
$.getJSON('ajax/test.json', function(data) {
hasItems = true;

    //Remove all items
    //Fill drop down with data from JSON
if (!hasItems)
{
    //Remove all items
    //Fill drop down with default value
}

});

answered May 13, 2011 at 1:27

J.W.

18.2k7 gold badges47 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

alex · Accepted Answer · 2011-05-13 01:27:04Z

6

You want to do all checking of returned data inside the callback, otherwise that condition will be called before the callback has been called, resulting in it always being the initial value assigned.

answered May 13, 2011 at 1:27

alex

492k205 gold badges890 silver badges992 bronze badges

Comments

Chris Moschini · Accepted Answer · 2011-05-13 01:38:49Z

1

You're dealing with asynchrony, so you need to think of the code you're writing as a timeline:

+ Some code
+ Fire getJSON call
|
| server working
|
+ getJSON call returns and function runs

The code inside the function happens later than the code outside it.

Generally:

// Setup any data you need before the call

$.getJSON(..., function(r) { //or $.ajax() etc
    // Handle the response from the server
});

// Code here happens before the getJSON call returns - technically you could also
// put your setup code here, although it would be weird, and probably upset other
// coders.

answered May 13, 2011 at 1:38

Chris Moschini

38.2k19 gold badges167 silver badges196 bronze badges

Collectives™ on Stack Overflow

jQuery/javascript basic logic question

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related