Call to a member function fails() on array error when using laravel Request classses

Question

I'm using a custom request class for laravel form validations.

This is my request class

class ContactUsRequest extends FormRequest
{
    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'lname' => 'required'
        ];
    }

   /**
   * Get the error messages for the defined validation rules.
   *
   * @return array
   */
    public function messages()
    {
        return [
            'lname.required' => 'please enter the last name'
        ];
    }

    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }
}

And this is where I call it,

public function send(ContactUsRequest $request) {
        $validator = $request->validated();

        if ($validator->fails()) {
            return redirect('/contactus')
                            ->withErrors($validator)
                            ->withInput();
        } else {
            ContactUs::create($request->all());

            return redirect('/contactus');
        }
    }

But when I input correct values I get this,

Symfony \ Component \ Debug \ Exception \ FatalThrowableError (E_ERROR) Call to a member function fails() on array

AH.Pooladvand · Accepted Answer · 2020-02-26 07:52:43Z

1

That's because request object automatically do that for you and you don't need to redirect back manually and $validator variable contains validated inputs so in your case you don't need to do anything and you can remove if and redirect safely

public function send(ContactUsRequest $request) {
            ContactUs::create($request->validated());

            return redirect('/contactus');
        }
    }

answered Feb 26, 2020 at 7:52

AH.Pooladvand

2,0792 gold badges15 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Foued MOUSSI · Accepted Answer · 2020-02-26 08:15:27Z

1

Using form request classes

If validation fails, a redirect response will be generated automatically to send the user back to their previous location. The errors will also be flashed to the session so they are available for display. If the request was an AJAX request, a HTTP response with a 422 status code will be returned to the user including a JSON representation of the validation errors.

In order to capture validation failure you may use the Validator facade

E.g

use Illuminate\Support\Facades\Validator;
//...

public function send(Request $request) {
        $validator = Validator::make($request->all(), [
            'lname' => 'required'
            // ...
        ]);

        if ($validator->fails()) {
            return redirect('/contactus')
                            ->withErrors($validator)
                            ->withInput();
        }

        ContactUs::create($request->all());

        return redirect('/contactus');
}

Form Request Validation Documentation

Manually Creating Validators Documentation

And we can keep ContactUsRequest like this.

public function send(ContactUsRequest $request) {
        $validator = $request->validated();

        ContactUs::create($request->all());

        return redirect('/contactus');
}

edited Feb 26, 2020 at 8:15

answered Feb 26, 2020 at 7:40

Foued MOUSSI

4,8334 gold badges21 silver badges40 bronze badges

5 Comments

vimuth Over a year ago

Thanks @foued-moussi. I added a little code and hope it's correct :)

vimuth Over a year ago

Need to use ContactUsRequest class alsooo :)

Foued MOUSSI Over a year ago

in cas of injecting ContactUsRequest $requestin your send method the Validator::make()will be ignored in case of failure.

vimuth Over a year ago

Think we doesn't need t since that part will be handled with custom request class. Can I add custom request class also to your code so I can accept ;)

Foued MOUSSI Over a year ago

I rejected your suggest edit by mistake, could you redo it ?

Collectives™ on Stack Overflow

Call to a member function fails() on array error when using laravel Request classses

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related