Bash script requires parameter

Question

Below is my bash script.

#!/bin/bash
message=$1
hostname=$2
severity=$3
eventname=$4
tagpath=$5
appname=$6
data="{"action":"EventsRouter","method":"add_event","data":[{"summary":"$message"},"device":"$hostname","message": "$message $eventname $tagpath","component":"$appname","severity":"$severity","evclasskey":"nxlog","evclass":"/nxlog/perf","monitor":"localhost"}],"type":"rpc","tid":1}"

echo "Total number of args : $#"

echo "message = $message"
echo "hostname = $hostname"
echo "appname = $appname"
echo "data = $data"

curl -u uname:password -k https://myurlcom/zport/dmd/evconsole_router -d $data

and when i try to run with sh tcp.sh value value value value value value

host:
'host,component:host,severity:host,evclasskey:nxlog,evclass:/nxlog/perf,monitor:localhost}],type:rpc,tid:1}'
is not a legal name (unexpected end of input) Total number of args : 6
message = message hostname = test appname = host data = curl: option
-d: requires parameter

I see that data has no value included. This json has to be sent in this order for it to be accepted in the endpoint. Help me correct this.

I recommend using a tool like jq to generate valid JSON, rather than relying on parameter expansion to do so. — chepner
– chepner, Commented May 14, 2020 at 16:09

chepner · Accepted Answer · 2020-05-14 16:16:08Z

2

Using jq to safely generate the desired JSON:

#!/bin/bash

parameters=(
  --arg message "$1"
  --arg hostname "$2"
  --arg severity "$3"
  --arg eventname "$4"
  --arg tagpath "$5"
  --arg appname "$6"
)

data=$(jq -n "${parameters[@]}" '
  {action: "EventsRouter",
   method: "add_event",
   data: [ {summary: $message, 
            device: $hostname,
            message: "\($message) \($eventname\) \($tagpath)",   
            component: $appname,
            severity: $severity,
            evclasskey: "nxlog",
            evclass: "/nxlog/perf",
            monitor: "localhost"
            }
          ],
   type: "rpc",
   tid: 1
  }'


curl -u uname:password -k https://myurlcom/zport/dmd/evconsole_router -d "$data"

answered May 14, 2020 at 16:16

chepner

538k77 gold badges594 silver badges746 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Pierre François · Accepted Answer · 2020-05-14 16:11:29Z

1

Assuming:

message="my_message"
hostname="my_host"
severity="my_severity"
eventname="my_event"
tagpath="my_path"
appname="my_app"

If you run:

data="{"action":"EventsRouter","method":"add_event","data":[{"summary":"$message"},"device":"$hostname","message": "$message $eventname $tagpath","component":"$appname","severity":"$severity","evclasskey":"nxlog","evclass":"/nxlog/perf","monitor":"localhost"}],"type":"rpc","tid":1}"

you will get an error, because there is a not escaped white space before the string "my_event"

my_event: command not found

What happened? Since your json input has a lot of words between double quotes, you will have to enclose the whole string into single quotes, in order to preserve the double quotes inside of the string. But between single quotes, the bash variables will not be replaced by their value. So you will need to close the single quotes before each variable and reopen these again immediately after.

So that line of your script must become:

data='{"action":"EventsRouter","method":"add_event","data":[{"summary":"'$message'"},"device":"'$hostname'","message": "'$message $eventname $tagpath'","component":"'$appname'","severity":"'$severity'","evclasskey":"nxlog","evclass":"/nxlog/perf","monitor":"localhost"}],"type":"rpc","tid":1}'

If you execute:

echo "$data"

you will get:

{"action":"EventsRouter","method":"add_event","data":[{"summary":"my_message"},"device":"my_host","message": "my_message my_event my_path","component":"my_app","severity":"my_severity","evclasskey":"nxlog","evclass":"/nxlog/perf","monitor":"localhost"}],"type":"rpc","tid":1}

which is correct, I assume: the double quotes didn't disappear from your json data structure.

edited May 14, 2020 at 16:11

answered May 14, 2020 at 13:35

Pierre François

6,1681 gold badge21 silver badges42 bronze badges

6 Comments

AlisonGrey Over a year ago

This is not working for me, i also realize there is an extra } after "summary":"my_message"} , which i corrected, and provided "'$message'". @Pierre

Pierre François Over a year ago

Probably, there are more errors, but my answer fixes at least one.

AlisonGrey Over a year ago

I removed the concatenated part and then it seemed to work. Is this the only way of concatenating multiple fields in bash?

Pierre François Over a year ago

I think "message": "my_message" "my_event" "my_path" is wrong. The value should be only one string instead of three. I corrected that also into "message": "my_message my_event my_path".

AlisonGrey Over a year ago

Okay, If i do want to have them concatenated, how do i do it? just curious @Pierre

|

Collectives™ on Stack Overflow

Bash script requires parameter

2 Answers 2

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related