How to assign a random integer to every object in an array JavaScript

Question

Edited to include a reproducible example. When a new task is created, a quantity can be input to create multiple tasks with the same data. In this case, the quantity is 3, so three tasks will be created with the other name:value pairs within the newtaskconfig object. The quantity is used in the for loop to push that many tasks to the newtasks array. An id with a random three digit integer is then assigned to each object within the newtasks array.

newtaskconfig = {
  site: 'YeezySupply',
  findby: 'URL',
  urlorpid: 'test.com',
  useproxies: 'TRUE',
  quantity: 3
}
quantity = Number(newtaskconfig.quantity)
delete newtaskconfig.quantity
newtasks=[]
for (i = 0; i < quantity; i++)  
{ 
  newtasks.push(newtaskconfig)
}
newtasks.forEach(task=>{
  task.id=Math.floor(Math.random()*(900)+100)
})

When I then log the newtasks array to console, instead of each object having a unique id, they all end up with the exact same one, shown here:

[
  {
    site: 'YeezySupply',
    findby: 'URL',
    urlorpid: 'test.com',
    useproxies: 'TRUE',
    id: 346
  },
  {
    site: 'YeezySupply',
    findby: 'URL',
    urlorpid: 'test.com',
    useproxies: 'TRUE',
    id: 346
  },
  {
    site: 'YeezySupply',
    findby: 'URL',
    urlorpid: 'test.com',
    useproxies: 'TRUE',
    id: 346
  }
]

How can I change my approach so that each object within the array is assigned a unique three digit id?

It seems like the problem is that your array contains multiple references to the same object. Or you were just very unlucky. — jonrsharpe
– jonrsharpe, Commented May 22, 2020 at 8:02
Your "array of objects" is just an array of three pointers to the same object. — Niet the Dark Absol
– Niet the Dark Absol, Commented May 22, 2020 at 8:02
Yes, as these are three unique tasks, which is why I am intending to assign them a unique id. — jokz
– jokz, Commented May 22, 2020 at 8:04
I'm not sure what you think you're saying yes to. You might consider them unique tasks, but it seems like they're actually not even separate objects. Give a minimal reproducible example, if you create them with literals as shown, the code you've posted works. — jonrsharpe
– jonrsharpe, Commented May 22, 2020 at 8:07
I have tried my best to edit my question to provide this, please let me know if you need more clarity — jokz
– jokz, Commented May 22, 2020 at 8:17

Siva Kondapi Venkata · Accepted Answer · 2020-05-22 09:37:01Z

1

Just change the line to newtasks.push({...newtaskconfig}), instead of newtasks.push(newtaskconfig) which causing have same ref.

Update: as @jonrsharpe suggest, simplify the code to the following.

newtaskconfig = {
  site: "YeezySupply",
  findby: "URL",
  urlorpid: "test.com",
  useproxies: "TRUE",
  quantity: 3
};

const { quantity, ...rest } = newtaskconfig;
const newtasks = new Array(quantity)
  .fill(0)
  .map(() => ({ ...rest, id: Math.floor(Math.random() * 900 + 100) }));

console.log(newtasks);

edited May 22, 2020 at 9:37

answered May 22, 2020 at 9:21

Siva Kondapi Venkata

11.1k2 gold badges20 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jonrsharpe Over a year ago

You could simplify to newtasks.push({ ...newtaskconfig, id: ... }). Note that this is only a shallow clone.

Siva Kondapi Venkata Over a year ago

Thanks @jonrsharpe, Updated answer to further simplify.

Collectives™ on Stack Overflow

How to assign a random integer to every object in an array JavaScript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related