How to import functions from another file in NodeJS?

Question

I'm new in NodeJS, and I'm struggling a little bit on this. I'm using Express and to validate the data, I'm using Celebrate.

I've got a route.js file, where I make a POST request, using a function from another file to do so (it's the create function, from MyController. It works fine! But when I try to do the same thing to my validator, it doesn't work.

So let's take a look at the code.

The route.js file:

const express = require("express");

const MyController = require("./controllers/MyController");
const MyValidator= require("./validators/MyValidator");

const routes = express.Router();

routes.post("/path", MuValidator.validateCreate, MyController.create);

The MyValidator file:

module.exports = {

  validateCreate() {
    celebrate({
      [Segments.HEADERS]: Joi.object({
        authorization: Joi.string().required(),
      }).unknown(),
      [Segments.BODY]: Joi.object().keys({
        userId: Joi.string().required(),
        title: Joi.string().required(),
        description: Joi.string().required(),
        value: Joi.number().required(),
        dueDate: Joi.string().required(),
      }),
    });
  },
}

IMPORTANT: I only get this working, if I write the validation code directly on my route, like this:

routes.post(
  "/path",
  celebrate({
    [Segments.HEADERS]: Joi.object({
      authorization: Joi.string().required(),
    }).unknown(),
    [Segments.BODY]: Joi.object().keys({
      userId: Joi.string().required(),
      title: Joi.string().required(),
      description: Joi.string().required(),
      value: Joi.number().required(),
      dueDate: Joi.string().required(),
    }),
  }),
  MyController.create
);

Define it doesn't work

Ayush Gupta
– Ayush Gupta

2020-05-22 14:00:11 +00:00
Commented May 22, 2020 at 14:00 — Ayush Gupta
– Ayush Gupta, Commented May 22, 2020 at 14:00
@AyushGupta, but is it something I'm doing wrong?

Marcelo Melo
– Marcelo Melo

2020-05-22 14:00:57 +00:00
Commented May 22, 2020 at 14:00 — Marcelo Melo
– Marcelo Melo, Commented May 22, 2020 at 14:00

Ridjvan Hajanirina · Accepted Answer · 2020-05-22 14:25:22Z

2

the problem is that the celebrate function creates and returns a middleware, so the middleware returned by the celebrate function must be passed as second parameter to the post but you're passing a function that execute the celebrate method instead, so validateCreate should be:

module.exports = {
    validateCreate: celebrate({...})
}

edited May 22, 2020 at 14:25

answered May 22, 2020 at 14:12

Ridjvan Hajanirina

1265 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

mars328 · Accepted Answer · 2020-05-22 14:07:23Z

1

I think you did something wrong with module exports

try something like this:

module.exports = {
    validateCreate: function() {},
    otherMethod: function() {},
};

answered May 22, 2020 at 14:07

mars328

5733 gold badges9 silver badges27 bronze badges

Collectives™ on Stack Overflow

How to import functions from another file in NodeJS?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related