checking array strings with foreach in javascript

Question

I'm brand new to this so if I'm not explaining the problem as I should, please let me know!

I'm basically using Twilio Quest as a way to start learning Javascript and have gotten myself a little stuck.

The challenge is to test the conditions of an array of strings and increase the value of a variable every time a certain string appears ... then return the value of said variable at the end of the function.

Here's what I have:

let freightItems = ['contraband', 'clear', 'contraband', 'clear'];
freightItems.forEach(scan);

function scan(freightItems) {

    const contrabandCount = 0;

        if (freightItems.element == 'contraband') {
            contrabandCount + 1;
        }

    return contrabandCount;

}

The error I'm getting when I submit the code to TwilioQuest is:

Your function returned a number, but not the value we were looking for. Your function should examine every item in the input array, and return the total number of times the string "contraband" appeared.

The line contrabandCount + 1; doesn't change the value of contrabandCount. You have to store the result in contrabandCount: contrabandCount = contrabandCount + 1 (or contrabandCount += 1) — Andreas
– Andreas, Commented Jun 7, 2020 at 14:44
You are treating the strings as objects when you do freightItems.element. Also a return in forEach callback has nowhere to return to — charlietfl
– charlietfl, Commented Jun 7, 2020 at 14:44
What is the expected output? it's not really clear here. you're trying to count the occurrences of a word, ok, but you have to store that value... where? Right now you're not storing it anywhere (other than being wrong, as others are explaining) — Balastrong
– Balastrong, Commented Jun 7, 2020 at 14:45

Yousaf · Accepted Answer · 2020-06-07 14:53:27Z

3

Couple of problems in your code:

you should iterate over the array inside the scan function because you can't return contrabandCount variable like you are trying to. Move the forEach loop inside the scan function
change
```
contrabandCount + 1;
```
to
```
contrabandCount = contrabandCount + 1;
```
because you need to update the contrabandCount variable with the result of contrabandCount + 1

let freightItems = ['contraband', 'clear', 'contraband', 'clear'];

function scan(freightItems) {
  let contrabandCount = 0;
  
  freightItems.forEach(str => {
    if (str === 'contraband') {
        contrabandCount = contrabandCount + 1;
    }
  })
  
  return contrabandCount;
}

console.log(scan(freightItems))

edited Jun 7, 2020 at 14:53

answered Jun 7, 2020 at 14:46

Yousaf

29.5k6 gold badges54 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Balastrong · Accepted Answer · 2020-06-07 14:48:58Z

0

This can be a solution

let contrabandCount = 0;

let freightItems = ['contraband', 'clear', 'contraband', 'clear'];
freightItems.forEach(el => {
  if (el === 'contraband') {
    contrabandCount++;
  }
});

console.log(contrabandCount);

If you're not forced to use a forEach:

let freightItems = ['contraband', 'clear', 'contraband', 'clear'];
let contrabandCount = freightItems.filter(el => el === 'contraband').length
console.log(contrabandCount);

answered Jun 7, 2020 at 14:48

Balastrong

4,4602 gold badges14 silver badges32 bronze badges

Collectives™ on Stack Overflow

checking array strings with foreach in javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related