Java Script for loop

Question

I want the loop to run until the value of prompt but it's going infinite. Need help. Here is my javascript code: My code

var round = prompt("enter text");
var roundno = round;

var images_arr = ["../img/paper.png", "../img/stone.png", "../img/sisor.png"];
var size = images_arr.length
function myFunction() {
for (var i = 0; i = roundno; i + 1) {
    console.log(i);
    setInterval(function () {
        var x = Math.floor(size * Math.random())
        $('#random').attr('src', images_arr[x]);
    }, 1500);

    setInterval(function () {
        var sound = new Audio("../audio/audio.mp3");
        sound.play();
    }, 3000);

    if (i = roundno) {
        break;
     }
    }
  }

Rickard Elimää · Accepted Answer · 2020-06-21 13:56:20Z

2

There are a lot of problems with your code.

var round = prompt("enter text"); // how do you know the user enters a number?
var defaultNumberOfRounds = 1;  // I added this row

// CHANGED THIS IN EDIT 
var roundno = round; // should be: isNaN(Number(round)) ? defaultNumberOfRounds : round

var images_arr = ["../img/paper.png", "../img/stone.png", "../img/sisor.png"];
var size = images_arr.length
function myFunction() {

// CHANGED THIS IN EDIT the conditions within () should be: var i = 0; i < roundno; i++
for (var i = 0; i = roundno; i + 1) {
    console.log(i);

    // all iterations in the loop will execute this at the same time.
    setInterval(function () {
        var x = Math.floor(size * Math.random())
        $('#random').attr('src', images_arr[x]); // JQuery
    }, 1500);

    // all iterations in the loop will execute this at the same time.
    setInterval(function () {
        var sound = new Audio("../audio/audio.mp3");
        sound.play();
    }, 3000);

    if (i = roundno) { // should be i == roundno
        break; // don't need to break it, because your for loop's condition should take care of this
     }
    }
  }
} // ADDED THIS IN EDIT: missing curly bracket

[edit] I added a snippet to show that my code is working. I commented all code within the for loop, and I had to change declaring roundno and the statement within the for loop.

var round = prompt("enter text");
var defaultNumberOfRounds = 1;
var roundno = isNaN(Number(round)) ? defaultNumberOfRounds : round;
var images_arr = ["../img/paper.png", "../img/stone.png", "../img/sisor.png"];
var size = images_arr.length;
console.log(`round: ${round}, roundno: ${roundno}`);
function myFunction() {
  for (var i = 0; i < roundno; i++) {
    console.log(i);

    /*setInterval(function () {
        var x = Math.floor(size * Math.random())
        $('#random').attr('src', images_arr[x]); // JQuery
    }, 1500);

    setInterval(function () {
        var sound = new Audio("../audio/audio.mp3");
        sound.play();
    }, 3000);*/

  }
}

myFunction();

edited Jun 21, 2020 at 13:56

answered Jun 20, 2020 at 11:24

Rickard Elimää

7,6763 gold badges18 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Mayank saini Over a year ago

I have tried doing all those changes but it still doesn't work.

Rickard Elimää Over a year ago

I made a mistake, and also discovered a missing bracket. I change part of the code and also made a snippet.

Mayank saini Over a year ago

Thank you so very much for helping me out with this. ;-)

Yousaf · Accepted Answer · 2020-06-20 11:30:24Z

2

You are not incrementing i

Change

i + 1

to one of the following:

i++
i += 1
i = i + 1

Also you need to fix the if statement at the end of the loop. You want to check whether i is equal to roundno or not. Instead of using assignment operator = which will assign the value of roundno to i, use == or === for equality check.

if (i == roundno) {
   break;
}

You have made the same typo in loop condition as well. Change loop condition to i == roundno and remove the if statement at the end of the loop because with loop condition fixed, if statement inside the loop is unnecessary.

for (var i = 0; i == roundno; i++) {
   // code
}

edited Jun 20, 2020 at 11:30

answered Jun 20, 2020 at 11:14

Yousaf

29.5k6 gold badges54 silver badges78 bronze badges

1 Comment

David Over a year ago

For completeness... i = i + 1 will also suffice, additionally there's a typo later on where the OP is assigning i to a new value. The condition later should be: if (i == roundno). Edit: The condition within the loop definition should also be i == roundno.

Collectives™ on Stack Overflow

Java Script for loop

2 Answers 2

3 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related