Create JSON Object tree from looped string without using eval()

Question

I have code that loops through a string to make a sort of tree in the form of a JSON Object. Every time a certain character is reached, the array should go down a level. The only way I have been able to accomplish this is with eval(). I recreate the index necessary to go down a row in a custom push function by generating something like this JSON_OBJECT[2][8].push(value). eval() is not only a security issue but is also pretty slow.

Below I have a similar script where I used a space as the certain character. When running 1,000 randomly generated filler words the script takes ~1000ms. By just removing the eval and replacing it with a json.push(value) the script takes at most 3ms.

I know that eval() wasn't using all of the time, but it has to be a big part. Speed is a big factor in the script and a 1,000 words is not very far off from what this script will be processing. Is there a way I can do this without eval()?

Here's the script

var string = 'lorem ipsum dolor sit amet consectetur adipiscing elit ut',
    json = [],
    levelIndex = [];

for (let i = 0; i < string.length; i++) {
  
  if (string[i - 1] == ' ') {
    levelIndex.push(deepestLength() - 1);
  }
  
  if (string[i] == ' ') {
    customPush([]);
  } else {
    customPush(string[i]);
  }
}

function customPush(value) {
  let path = '';

  for (let i = 0; i < levelIndex.length; i++) {
    path += '[' + levelIndex[i] + ']';
  }
  
  eval('json' + path + '.push(' + JSON.stringify(value) + ')');  
}

function deepestLength() {
  let deepest = json;
  
  for (let i = 0; i < levelIndex.length; i++) deepest = deepest[levelIndex[i]];
  
  return deepest.length;
}

document.write('Completed Array: <br>' + JSON.stringify(json));

See stackoverflow.com/questions/34054601/…

Barmar
– Barmar

2020-07-01 19:48:18 +00:00
Commented Jul 1, 2020 at 19:48 — Barmar
– Barmar, Commented Jul 1, 2020 at 19:48

AKX · Accepted Answer · 2020-07-01 19:48:02Z

1

Sure thing. Try this:

function x(string, marker) {
  var root = [];
  var current = root;
  for(var i = 0; i < string.length; i++) {
    if(string[i] === marker) {
      var newCurrent = [];
      current.push(newCurrent);
      current = newCurrent;
    } else {
      current.push(string[i]);
    }
  }
  return root;
}
var result = x('lorem ipsum dolor sit amet consectetur adipiscing elit ut', " ");
console.log(result);
console.log(JSON.stringify(result));

answered Jul 1, 2020 at 19:48

AKX

171k16 gold badges146 silver badges228 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jack Over a year ago

Thanks. I knew that there had to be a better way. My first thought was to do it the way you did, but I assumed that assigning a current wouldn't update the root once changed.

UserTest013 · Accepted Answer · 2020-07-01 20:17:35Z

1

you can try this approach:

function deep(nodes, separator) {
  return nodes
    .split(separator)
    .reduceRight((result, element) => {
      result.unshift(...element.split(""));
      return [ result ];
    }, []);
}

var result = deep("lorem ipsum dolor sit amet consectetur adipiscing elit ut", " ");
console.log(JSON.stringify(result));

answered Jul 1, 2020 at 20:17

UserTest013

5637 silver badges17 bronze badges

1 Comment

Jack Over a year ago

Thanks for your answer. The code is super concise but it seems significantly slower than AKX's answer.

Hillel Buchsbaum · Accepted Answer · 2020-07-01 21:11:04Z

0

Late to the party, but this works using recursion, and the fact that arrays are passed by reference, not value.

var string = "Lorem ipsum dolor sit amet consectetur adipiscing elit ut";
let myjson = [];

let recursiveDrillandAppend = (array, value) => {
  if (!Array.isArray(array)) return true;

  if (recursiveDrillandAppend(array[array.length - 1], value))
    array.push(value);
};

for (let i = 0; i < string.length; i++) {
  if (string[i] === " ") recursiveDrillandAppend(myjson, []);
  else recursiveDrillandAppend(myjson, string[i]);
}

document.write("Completed Array: <br>" + JSON.stringify(myjson) + "<br>");

answered Jul 1, 2020 at 21:11

Hillel Buchsbaum

865 bronze badges

Collectives™ on Stack Overflow

Create JSON Object tree from looped string without using eval()

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related