Something wrong with my modular JS code TypeError is not a function

Question

I was trying to modularise the JS code but stuck at a point for quite a long time, I know the solution will be easy but just can't figure it out. Here is the fiddle link: Fiddle.

Adding code here as well.

window.a = (function () {
  function abc() {
    alert("Hi");
  }
  return {
    abc: abc
  }
});


window.b = (function (aWindow) {
  function i() {
    aWindow.abc();
  }
  return {
    i: i
  }
})(window.a);

<a href="#" class="abc" onClick="window.b.i()">Click Me</a>

Error

"<a class='gotoLine' href='#60:10'>60:10</a> Uncaught TypeError: aWindow.abc is not a function"

you're missing () for the first IIFE - i.e. otherwise it's NOT an IIFE and window.a is just that function as you've written it - either that or do })(window.a()) — Jaromanda X
– Jaromanda X, Commented Oct 14, 2020 at 3:52

Tércio Garcia · Accepted Answer · 2020-10-14 03:54:31Z

2

You need to call window.a to obtain an object from its prototype.


window.b = (function(aWindow) {

  function i() {
    aWindow.abc();
  }

  return {
    i: i
  }

})(window.a()); //Call Window.a

answered Oct 14, 2020 at 3:54

Tércio Garcia

4373 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

kangaswad · Accepted Answer · 2020-10-14 04:06:09Z

2

You missed () when calling aWindow. This snippet works well.

window.a = (function () {
  function abc() {
    alert("Hi");
  }
  return {
    abc: abc
  }
});


window.b = (function (aWindow) {
  function i() {
    aWindow().abc();
  }
  return {
    i: i
  }
})(window.a);

<a href="#" class="abc" onClick="window.b.i()">Click Me</a>

answered Oct 14, 2020 at 4:06

kangaswad

7856 silver badges12 bronze badges

Comments

Derek Wang · Accepted Answer · 2020-10-14 03:54:39Z

1

You have missed () on window.a definition so it's not executed.

window.a = (function () {
  function abc() {
    alert("Hi");
  }
  return {
    abc: abc
  }
})();

window.b = (function (aWindow) {
  function i() {
    console.log(aWindow);
    window.a.abc();
  }
  return {
    i: i
  }
})(window.a);

<a href="#" class="abc" onClick="window.b.i()">Click Me</a>

answered Oct 14, 2020 at 3:54

Derek Wang

10.2k4 gold badges20 silver badges40 bronze badges

2 Comments

Abhishek Over a year ago

I knew it was something small but could not figure it out any reference to read this concept and clear it out in-depth once for all. Thanks for the help

Derek Wang Over a year ago

This will help. javascripttutorial.net/…

Collectives™ on Stack Overflow

Something wrong with my modular JS code TypeError is not a function

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related