Append query string to url

Question

I have a callback url string params[:callback] and I need to append a query string "&result=true" and redirect the user. The better way I found of doing this is using addressable but I think the code is too big for task like this especially when we are talking about ruby:

callback = Addressable::URI.parse(params[:callback])
query = callback.query_values
query[:result] = 'true'
callback.query_values = query

redirect_to callback.to_s

Is there a more elegant way of getting the same result as this snippet?

Mauno Vähä · Accepted Answer · 2014-11-27 08:51:10Z

15

I wan't to bring update to this topic, because any of the solutions didn't work me.

The reason being, that it seems that callback.query_values returns Nil if the actual url doesn't have existing query values.

Therefore if you have urls such as: http://www.foo.com and http://www.foo.com?bar=1 you should use the following code:

url = "http://www.foo.com" # or params[:callback] obviously. :)

callback = Addressable::URI.parse(url)
callback.query_values = (callback.query_values || {}).merge({
  result: true
})

redirect_to callback.to_s

Cheers.

answered Nov 27, 2014 at 8:51

Mauno Vähä

9,7883 gold badges36 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Arye Eidelman Over a year ago

I just want to add that If the param may already exist make sure that "result" is a string, not a symbol :result so you don't get a double param like "foo.com?result=true&result=true" or "foo.com?result=true&result=false". Also if true is a boolean result: true and not a string result: "true" this can raise an ArgumentError (comparison of Array with Array failed)

Anton Rogov · Accepted Answer · 2011-07-03 08:50:25Z

9

if you don't need any URL validations you can do this (looks a little bit dirty):


url = params[:callback]
redirect_to url + (url.include?('?') ? '&' : '?') + 'result=true'

otherwise you have to use either some external library (like Addressable) or URI module from standard library

answered Jul 3, 2011 at 8:50

Anton Rogov

1892 bronze badges

1 Comment

MIchel Over a year ago

yeah, it looks dirty. Looking at my code using Addressable is there anyway this code could be shorter ?

ehaselwanter · Accepted Answer · 2011-07-20 17:59:21Z

3

callback.query_values = callback.query_values.merge({"result" => "true"})

answered Jul 20, 2011 at 17:59

ehaselwanter

695 bronze badges

1 Comment

FeifanZ Over a year ago

Mauna's answer below is better because callback.query_values can return nil, which does not respond to merge

Mainguy · Accepted Answer · 2012-02-22 13:55:55Z

0

I think you're pretty close to optimal. you could crush out a line or two, but it doesn't really gain you anything.

callback = Addressable::URI.parse(params[:callback])
callback.query_values = callback.query_values.merge {:results => 'true' }
redirect_to callback.to_s

If the callback is always inside your application, you might have some other options with varying degrees of coolness, but you didn't specify if that was the case or not.

answered Feb 22, 2012 at 13:55

Mainguy

1,68913 silver badges12 bronze badges

Comments

installero · Accepted Answer · 2022-01-19 07:34:11Z

0

years later, I find a better solution of this problem.

Get the value from the super first, then do any tweaks we need using Addressable

def url_for(options={})
  val = super

  if params[:locale].present?
    parsed = Addressable::URI.parse(val)
    query_array = parsed.query_values(Array) || []
    query_array << ['locale', params[:locale]]
    parsed.query_values = query_array
    val = parsed.to_s
  end

  val
end

edited Jan 19, 2022 at 7:34

installero

9,8663 gold badges46 silver badges50 bronze badges

answered Dec 5, 2014 at 14:50

YANKE Guo

11 bronze badge

Comments

installero · Accepted Answer · 2022-01-17 14:08:29Z

-1

Let me offer this one modestly. I suggest using only strings for query parameters keys and values (like Arye noted) . Also, NilClass instances have a to_h method, which allows to remove some brackets:

callback = Addressable::URI.parse(params[:callback])

callback.query_values = callback.query_values.to_h.merge("result" => "true")

redirect_to callback.to_s

answered Jan 17, 2022 at 14:08

installero

9,8663 gold badges46 silver badges50 bronze badges

Comments

Pierre · Accepted Answer · 2011-07-03 10:24:08Z

-3

You can try with merge

request.parameters.merge({:result => true})

this will add your parameter to the ones already defined.

answered Jul 3, 2011 at 10:24

Pierre

8,3384 gold badges36 silver badges50 bronze badges

1 Comment

Gareth Over a year ago

OP has the URL in a variable. It's not the current request URL

Collectives™ on Stack Overflow

Append query string to url

7 Answers 7

1 Comment

1 Comment

1 Comment

Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

1 Comment

1 Comment

1 Comment

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related