MySQL Query Not Working PHP

Question

I have a query I'm trying to build so that I can filter by car brand. But if a certain session variable exists, it'll ask for an extra part to be added to the query which is basically limiting the results to the logged in branch. Here's the query:

$query_AUCTION = "SELECT * 
          FROM at_auction AS a 
          JOIN at_brands AS b ON a.aCarBrandID = b.bid 
      ORDER BY b.brand $orderx";

... now this works but where can I add a:

"WHERE bid = '{$bid}'"? ...or a... "AND bid = '{$bid}'";

It brings up an error.

"brings up an error" - why do you think you should not tell us what that error is?! — OMG Ponies
– OMG Ponies, Commented Jul 11, 2011 at 20:04
SORRY it was just a check your syntax error!!! Thanks for answers everyone. — Matt Reid
– Matt Reid, Commented Jul 11, 2011 at 22:09

Tremmors · Accepted Answer · 2011-07-11 20:04:26Z

2

insert your where clauses BEFORE your order by

$query_AUCTION = "SELECT * FROM at_auction AS a JOIN at_brands AS b ON a.aCarBrandID = b.bid WHERE bid = '{$bid}' ORDER BY b.brand $orderx";

answered Jul 11, 2011 at 20:04

Tremmors

2,98619 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

CristiC · Accepted Answer · 2011-07-11 20:06:20Z

1

Use a generic WHERE 1=1 and if you want to insert additional condition:

$query_AUCTION = "SELECT * 
          FROM at_auction AS a 
          JOIN at_brands AS b ON a.aCarBrandID = b.bid
          WHERE 1=1 ";

if ($bid > 0)
   $query_AUCTION .= " AND bid = '{$bid}' ";

$query_AUCTION .= " ORDER BY b.brand $orderx";

answered Jul 11, 2011 at 20:06

CristiC

22.7k13 gold badges62 silver badges89 bronze badges

1 Comment

DonSeba Over a year ago

using WHERE 1=1 is bad practice. and not needed in this case

DonSeba · Accepted Answer · 2011-07-11 20:19:03Z

1

try this :

$query_AUCTION = "SELECT * 
                  FROM at_auction AS a 
                  JOIN at_brands  AS b ON ( b.bid = a.aCarBrandID ) ";

if( isset( $_SESSION['bid'] ) )
{
    $query_AUCTION.= " WHERE b.bid = '".$_SESSION['bid']."'";
}

$query_AUCTION.= " ORDER BY b.brand $orderx";

edited Jul 11, 2011 at 20:19

answered Jul 11, 2011 at 20:07

DonSeba

2,1192 gold badges16 silver badges25 bronze badges

Collectives™ on Stack Overflow

MySQL Query Not Working PHP

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related