Php array search not working

Question

Hi really need help here is my function.

function isdAuthorTrue( $post_id ) { 


    $coauthors = get_post_meta( $post_id, "coAuthors" );

    print_r($coauthors);
    // print_r output Array ( [0] => 78 )

     $key = array_search( 78, $coauthors );
     $key = 0;
     if($key !== false) {

       return true;

     } else {

         return false;
          }
}

then i am trying to do and if statement around it that isnt working.

$test = isdAuthorTrue( 102 );

echo $test;

if($test){

    echo "yes";

}else{

    echo "no";
}

i keep getting no what am i doing wrong???

wanovak · Accepted Answer · 2011-07-13 16:54:42Z

6

You're getting "no" because array_search returns the key, in this case, 0. PHP evaluates that as false. Edit: didn't notice the strict comparison -- no it doesn't.

Also, you're explicitly setting $key to 0...

edited Jul 13, 2011 at 16:54

answered Jul 13, 2011 at 16:43

wanovak

6,12727 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Rudu Over a year ago

Uh no, user is using === not == (with magic type conversion) 0!==false, 0==false

Endophage Over a year ago

Not the case, he's using !== not != so types will be checked too. 0 == false will return true, 0 === false will not.

Rudu · Accepted Answer · 2011-07-13 16:50:11Z

1

As @marc points out, you can just use in_array... and simplify the whole function down to one line:

function isdAuthorTrue($post_id,$authorid=78) { 
    return in_array($authorid,get_post_meta( $post_id, "coAuthors"));
}

answered Jul 13, 2011 at 16:50

Rudu

15.9k4 gold badges51 silver badges66 bronze badges

Comments

Nicola Peluchetti · Accepted Answer · 2011-07-13 16:43:14Z

0

Array serach returns the key of the needle that is 0 that is false. You should do.

if($test !== false){

    echo "yes";

}else{

    echo "no";
}

answered Jul 13, 2011 at 16:43

Nicola Peluchetti

76.9k32 gold badges150 silver badges197 bronze badges

Comments

marc · Accepted Answer · 2011-07-13 16:44:56Z

0

Why do you set $key = 0? $key is the index. So it is never FALSE. Why not use in_array($needle, $haystack)?

answered Jul 13, 2011 at 16:44

marc

6,2431 gold badge31 silver badges33 bronze badges

Collectives™ on Stack Overflow

Php array search not working

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related