Selection sort not sorting integer array

Question

I'm trying to implement a selection sort that sorts an integer array but it doesn't do that. I can't figure out what's wrong so maybe another set of eyes can figure it out.

public static void main(String[] args) {
    int[] array = {900, 200, 23, -3, 1, 30, 55, -70, 100, 9};
    System.out.println(Arrays.toString(array));
    for (int i = array.length - 1; i > 0; i--) {
        int largest = 0;
        for (int j = 1; j <= i; j++) {
            if (array[j] > array[largest]) {
            }
            largest = j;
        }
        swap(array, largest, i);
    }
    System.out.println(Arrays.toString(array));
}

private static void swap(int[] arr, int i, int j) {
    if (i == j)
        return;
    int temp = arr[i];
    arr[i] = arr[j];
    arr[j] = temp;
}

Please see How do I ask a good question? and Minimal, Reproducible Example. "it doesn't do that" isn't very descriptive. Your post is suppose to help not just you, but anyone else that happens upon the same problem. — Scratte
– Scratte, Commented Apr 25, 2021 at 20:18

Community · Accepted Answer · 2021-04-26 16:41:57Z

1

Move largest = j into the if block

if (array[j] > array[largest]) {
    largest = j;
}

edited Apr 26, 2021 at 16:41

CommunityBot

11 silver badge

answered Apr 25, 2021 at 19:44

Rocco

1,1187 silver badges11 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Selection sort not sorting integer array

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related