Pass strings to function in a loop

Question

I have this code that activates when rollover, rollout, and release. I functions for rollover and rollout works, but the release function does not. I'm trying to pass some strings with url's to the function within a loop.

var url1:String = "http://www.google.com";
var url2:String = "http://www.google.com";
var url3:String = "http://www.google.com";
var url4:String = "http://www.google.com";
var url5:String = "http://www.google.com";
var url6:String = "http://www.google.com";
var url7:String = "http://www.google.com";
var url8:String = "http://www.google.com";
var url9:String = "http://www.google.com";
var url10:String = "http://www.google.com";
var url11:String = "http://www.google.com";
var url12:String = "http://www.google.com";


function SetMouseAction(buttonMC, arrowMC, dynamicTF, linkURL):Void {
    trace(linkURL);
    buttonMC.colorText = dynamicTF;
    buttonMC.onRollOver = function() {
        TweenLite.to(arrowMC,0.5,{_x:"2", _alpha:50, ease:Back.easeOut});
        this.colorText.textColor = 0x7cb0b7;
    };
    buttonMC.onRollOut = function() {
        TweenLite.to(arrowMC,0.5,{_x:37, _alpha:100, ease:Back.easeOut});
        this.colorText.textColor = 0xffffff;
    };
    buttonMC.onRelease = function() {
        if (linkURL) {
            getURL(linkURL);
        }
    };
}

for (var i:Number = 1; i<=12; i++) {
    SetMouseAction(this["link"+i],this["arrow"+i],this["text"+i],url+1);
}

I have a strong feeling that the url+1 in the for loop is wrong, but I don't know how to do it.

Any thoughts?

evilpenguin · Accepted Answer · 2009-03-25 14:26:42Z

1

var urls:Array = new Array();
urls.push("http://link1");
...
urls.push("http://link12");

function SetMouseAction(buttonMC, arrowMC, dynamicTF, linkURL):Void {
...
}

for (var i:Number = 1; i<=12; i++) {
    SetMouseAction(this["link"+i],this["arrow"+i],this["text"+i],urls[i]);
}

Make sure that the Array urls has at least 12 elements, or else you will get an index out of bounds error.

later edit: if you need to extract the urls from flashvars, just use a separator like "," and define a string with all your urls, like so: urlVars=url1,url2,url3,...,url12

Then in order to extract the urls and push them intor the array, you use the split function:

var urls:Array = new Array();
for (var i=0; i<urlVars.split(",").length; i++) urls.push(urlVars.split(",")[i]);

edited Mar 25, 2009 at 14:26

answered Mar 25, 2009 at 13:06

evilpenguin

5,4986 gold badges43 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

17 Comments

Sindre Sorhus Over a year ago

The problem is that I'm going to pass the urls as FlashVars with swfObject. Any thoughts on how I would do that?

evilpenguin Over a year ago

I edited the reply in order to fit your question, please check above.

Sindre Sorhus Over a year ago

I can't get it to work. Can you take a look at my code? HTML: pastebin.com/m50660ada Actionscript: pastebin.com/m1e0c177

evilpenguin Over a year ago

Your actionscript code doesn't seem to include the lines I suggested in the edit of my reply. Please make sure you give me the link to the most recent piece of code you wrote and make sure you include the two lines from the above answer.

Sindre Sorhus Over a year ago

Sorry, gave you the wrong version. Here's the right one: pastebin.com/m2f39f5f4

|

AnthonyWJones · Accepted Answer · 2009-03-25 12:52:06Z

1

Change url+1 to this["url"+i]

That'll get this code working. However you really should consider using an array called url with 12 elements rather than creating 12 individual variables.

answered Mar 25, 2009 at 12:52

AnthonyWJones

190k35 gold badges236 silver badges307 bronze badges

Collectives™ on Stack Overflow

Pass strings to function in a loop

2 Answers 2

17 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

17 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related