Php mysql query update of data gives syntax error

Question

This is my php code to update products in database:

$sql="UPDATE product SET name=$newname , price=$price , stock=$stock , color=$color WHERE id=$id";
if($conn->query($sql)){
    echo "product update";
}

It gives this error:

Error: UPDATE product SET name=samsung galaxy note 20 ultra , price=40000 , stock=5 , color=white WHERE id=1
You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'galaxy note 20 ultra , price=40000 , stock=5 , color=white WHERE id=1' at line 1

Does this answer your question? When to use single quotes, double quotes, and backticks in MySQL — Tangentially Perpendicular
– Tangentially Perpendicular, Commented Aug 18, 2021 at 9:26

Gerard de Visser · Accepted Answer · 2021-08-18 09:31:39Z

1

This code should work:

$sql="UPDATE product SET name='$newname', price='$price', stock='$stock', color='$color' WHERE id='$id';";

But a better approach would be to use parameterized prepared statements as you are vulnerable now to SQL injections. Also refer to: https://dev.mysql.com/doc/apis-php/en/apis-php-mysqli.quickstart.prepared-statements.html

edited Aug 18, 2021 at 9:31

answered Aug 18, 2021 at 9:26

Gerard de Visser

8,1009 gold badges54 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Maxx P · Accepted Answer · 2021-08-18 09:28:47Z

1

Put single quotes to variables which has string values like this

$sql="UPDATE product SET name='$newname' , price='$price' , stock=$stock , color='$color' WHERE id=$id";

answered Aug 18, 2021 at 9:28

Maxx P

1781 silver badge10 bronze badges

Comments

Andy · Accepted Answer · 2024-10-01 20:45:44Z

0

Please try this code.

$sql = "UPDATE product SET name='$newname', price=$price, stock=$stock, color='$color' WHERE id=$id";
if ($conn->query($sql)) {
    echo "Product updated";
}

answered Oct 1, 2024 at 20:45

Andy

922 silver badges10 bronze badges

Collectives™ on Stack Overflow

Php mysql query update of data gives syntax error

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related