How to scan an integer array

Question

I am new to C++. I am trying to define a binary converter function and return a pointer. Then U want to display generated binary in the main function:

#include <iostream>
using namespace std;

int* binary_con(int n)
{
    int i;
    int binary[100];
    for (i = 0; n > 0; i++)
    {
        binary[i] = n % 2;
        n = n / 2;
    }
    return binary;
}

int main()
{
    int n;
    int* a;
    cout << "Input the number:";
    cin >> n;
    a = binary_con(n);

    while (*a)
    {
        cout << *a;
        a++;
    }
    return 0;
}

But after I run my code, I got this:

Can anyone explain this to me?

One bug is return binary; you can't return a pointer to an array. The array no longer exists when the binary_con() function ends. — drescherjm
– drescherjm, Commented Oct 26, 2021 at 11:28
You also don't initialize the array and would only print ones, encountering a zero stops the printout. Which is not ideal for binary, the occasional zero is needed as well. — user14215102
– user14215102, Commented Oct 26, 2021 at 11:29
Using a vector instead of an array would solve both these problems. — interjay
– interjay, Commented Oct 26, 2021 at 11:31
You could also have the function output a std::string if all you are going to do is print the result. — drescherjm
– drescherjm, Commented Oct 26, 2021 at 11:32

hessam_kk · Accepted Answer · 2021-10-26 11:40:43Z

0

you can't return an array from a function, the way is to pass that array as an argument to the functionm using this approach:

void binary_con(int n, int *binary)

now you have access to binary array inside your function, hence you can edit it and see the changes outside of the function without returning anything.

inside your main, instead of writing a = binary_con(n);, you should write this: binary_con(n, a);

answered Oct 26, 2021 at 11:40

hessam_kk

3191 silver badge12 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to scan an integer array

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related