Syntax error when using conditional operator inside Stream.map

Question

I am working on a Java project where I have to use a Java stream to collect IDs of all the objects inside a list of objects.

Now I only want to collect IDs of those objects whose type matches a certain value.

What I am using:

List<String> skuGroupIds = skuGroupPagedResponseMap.getData().stream().map(this::getGroupId).collect(Collectors.toList());

Now I want to use the condition and I did this but this is giving syntax error:

List<String> skuGroupIds = skuGroupPagedResponseMap.getData().stream().map(group->group.getCreatedType().equals(SkuGroupCreationType.SKU_GROUP_LOT)?this::getGroupId:return null;).collect(Collectors.toList());

getGroupID function used inside map

private String getGroupId(SkuGroupResponseDTO skuGroupResponseDTO){
    return skuGroupResponseDTO.getSkuId() + Constants.HYPHEN + skuGroupResponseDTO.getId();
}

How can I fix this so it doesn't cause a syntax error?

Why not just use filter() and then map()?

Robby Cornelissen
– Robby Cornelissen

2022-04-07 04:49:42 +00:00
Commented Apr 7, 2022 at 4:49 — Robby Cornelissen
– Robby Cornelissen, Commented Apr 7, 2022 at 4:49

Chaosfire · Accepted Answer · 2022-04-07 05:36:40Z

1

Your lambda inside map(), should look like this:

.map(group -> group.getCreatedType().equals(SkuGroupCreationType.SKU_GROUP_LOT) ? this::getGroupId : null)

Or like this:

.map(group -> {
    return group.getCreatedType().equals(SkuGroupCreationType.SKU_GROUP_LOT) ? this::getGroupId : null;
})

But it would be much better to use a filter(), as mentioned in comments:

List<String> skuGroupIds = skuGroupPagedResponseMap.getData()
     .stream()
     .filter(group -> group.getCreatedType().equals(SkuGroupCreationType.SKU_GROUP_LOT))
     .map(this::getGroupId)
     .collect(Collectors.toList());

edited Apr 7, 2022 at 5:36

answered Apr 7, 2022 at 5:24

Chaosfire

7,1094 gold badges11 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Syntax error when using conditional operator inside Stream.map

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related