Bash script string with spaces arguments is not working

Question

Bash arguments with space not working, even I am using quotes in aruments

update_config_entry() {
  echo
  echo -e "${RED}CONFIG-UPDATE${NC} Ensure $1 is updated in $2"

  if grep -Fx $1 $2; then
    echo "$1 already exist in file $2"
  else
    echo $1 >> $2
  fi

  policystatus=$?

  if [[ "$policystatus" -eq 0 ]]; then
    echo -e "${GREEN}Remediated:${NC} Ensure $1 is updated in $2"
  else
    echo -e "${RED}UnableToRemediate:${NC} Ensure $1 is updated in $2"
fi

}

update_config_entry "install usb-storage /bin/true" /etc/modprobe.d/CIS.conf

Error:

grep: usb-storage: No such file or directory
grep: /bin/true": No such file or directory

"install usb-storage /bin/true" should go single argument but it is passing install usb-storage /bin/true as separate arument. what I am doing wrong,

other places recomended enclose with quotes and I am already doing it

Link

Bash script GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)

It is passed to your string as a single argument. You can verify it if you do something like echo ">>>$1<<<" at the start of your function update_config_entry `. — user1934428
– user1934428, Commented Apr 27, 2022 at 6:30

user1934428 · Accepted Answer · 2022-04-27 06:32:38Z

1

You forgot to quote the argument to grep. It should be

grep -Fx "$1" "$2"

otherwise grep receives

grep -Fx install usb-storage /bin/true /etc/modprobe.d/CIS.conf

which means that it is asked to search the file usb-storage.

answered Apr 27, 2022 at 6:32

user1934428

22.8k9 gold badges57 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dominique · Accepted Answer · 2022-04-27 07:48:14Z

0

I'm afraid that your double quotes are not sufficient. I tried the following:

update_config_entry """install usb-storage /bin/true""" /etc/modprobe.d/CIS.conf

It looked quite well.

answered Apr 27, 2022 at 7:48

Dominique

17.6k20 gold badges81 silver badges161 bronze badges

1 Comment

Gordon Davisson Over a year ago

The extra double-quotes don't do anything at all (each extra pair actually cancel each other out).

Dudi Boy · Accepted Answer · 2022-04-27 08:51:32Z

0

Suggesting fix:

update_config_entry() {
  echo
  echo -e "${RED}CONFIG-UPDATE${NC} Ensure $1 is updated in $2"

  if [[ $(grep -Fxc "$1" "$2") -ne 0 ]]; then
    echo "$1 already exist in file $2"
  else
    echo "$1" >> "$2"
  fi

  policystatus=$?

  if [[ "$policystatus" -eq 0 ]]; then
    echo -e "${GREEN}Remediated:${NC} Ensure $1 is updated in $2"
  else
    echo -e "${RED}UnableToRemediate:${NC} Ensure $1 is updated in $2"
fi

}

update_config_entry "install usb-storage /bin/true" /etc/modprobe.d/CIS.conf

answered Apr 27, 2022 at 8:51

Dudi Boy

1

Collectives™ on Stack Overflow

Bash script string with spaces arguments is not working

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related