PHP accessing variables problem on require() function

Question

I have a question about PHP require() function. I have a PHP script called (login.php) and on that (login.php) I use various require() functions to get heavy PHP coded scripts to work on that original script (login.php).

However I noticed on a require() script I can access local variables defined on the original (login.php). However the problem is say on that required script I have another require() function then those variables originally defined on (login.php) are lost (ie if I do an isset() says they are not set?). So how do you get around this require() within require() problem?

Any ideas perhaps using $_SESSION or $GLOBALS variables instead? I know about $_SESSION variables but are $GLOBALS variables secure?

Below is short example of script var set on (login.php)

if(!isset($header_displayed))
    {
        echo "<div id='header'>
            <div id='logo'></div>
        </div>";
        $header_displayed=1; 
    }

Then this script is called from above (login.php) using require()

if(!function_exists('writeErrors'))
    {
        function writeErrors($error,$host_details,$date,$page,$line) 
        {
            require("/home/darren/crash_msg/error_msg.php");
        }
    }

And then on error_msg script called the $header_displayed var is not set?

From feedback seems using require() within function will restrict all global vars. So you have to do this:

    if(!function_exists('writeErrors'))
    {
        function writeErrors($error,$host_details,$date,$page,$line, add var paramters that you need ie $header_displayed) 
        {
            /*log SQL stuff*/
            $display_error_msg=1;
require("/home/darren/crash_msg/error_msg.php"); /*now header_displayed var set on this script*/
        }
    }

On the secondarily included scripts, are you trying to access the globals inside a function? — Michael Berkowski
– Michael Berkowski, Commented Aug 28, 2011 at 11:01
just local variables defined on (login.php). On the first require() script I use a function and inside function is another require() function and on that required script the variables not exist? — daza166
– daza166, Commented Aug 28, 2011 at 11:04
You should post some code samples to help clarify your problem. But you probably have some variables overwriting each other because of name collision. — rogeriopvl
– rogeriopvl, Commented Aug 28, 2011 at 11:05

Michael Berkowski · Accepted Answer · 2011-08-28 11:38:38Z

7

According to your comment, you call require() inside a function. Therein lies your problem. When you include/require inside a function, then the included script inherits the scope of that function, which does not include the global variables defined in either your login.php script or the first script included by login.php.

It is best practice with globals to always call them as $GLOBALS['varname']. Note it isn't $_GLOBAL, but its own unique oddity.

Regarding security, it isn't any less secure to use $GLOBALS than anything else as long as register_globals is turned off (and it really really should be). It is just considered to be a sloppy practice to rely too much on globals, particularly on globals defined in other scripts.

It is typically better to pass the only the values needed as parameters to functions, or to store variables you know you will need all the time in $_SESSION.

It is not recommended to ever call an included file inside a function, since when reading the included file by itself you have no context for the scope it runs in. You would assume it executes in the global scope, but that is incorrect. To whatever degree possible, it is recommended to refactor your code to avoid including inside a function. For example, whatever executes inside the included file should be wrapped in a function with the needed global vars passed to it as parameters. Call that function in place of the require().

edited Aug 28, 2011 at 11:38

answered Aug 28, 2011 at 11:09

Michael Berkowski

271k47 gold badges450 silver badges395 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Your Common Sense Over a year ago

@daza166 read the manual page linked for you in 2 answers, PLEASE

daza166 Over a year ago

Thanks, sorted it out, you have to put the parameters of the vars into the function(parameters) otherwise required script inside function wont have those vars set. Best Answer

Michael Berkowski Over a year ago

@daza166 Your amended question does not change the answer.

Madara's Ghost · Accepted Answer · 2011-08-28 11:10:37Z

2

Included pages' variables are in the scope of those variables, so consider the following a.php, b.php and c.php:

a.php

$a = "a"; //This is a global variable, it will be avaliable in all files
include("b.php");
echo "A: \n"
var_dump($a, $b, $c);

b.php

$b = "b"; //This variable is also considered global, as it is scoped to the first, main document.
include("c.php");
echo "B: \n";
var_dump($a, $b, $c);

c.php

$c = "c"; //This variable will only show on b.php and c.php, it is scoped to b.php and its dependencies.
echo "C: \n";
var_dump($a, $b, $c);

The above will output:

C:
(all variables)

B:
(all variables)

A:
(only A and B)

See this link on ways to solve this issue.

answered Aug 28, 2011 at 11:10

Madara's Ghost

176k52 gold badges274 silver badges314 bronze badges

Comments

Your Common Sense · Accepted Answer · 2011-08-28 11:12:46Z

0

require() has nothing to do with variables visibility (at least as long as you're including files)
All variable scope issues belongs to functions use. http://www.php.net/manual/en/language.variables.scope.php

answered Aug 28, 2011 at 11:12

Your Common Sense

158k42 gold badges226 silver badges373 bronze badges

Collectives™ on Stack Overflow

PHP accessing variables problem on require() function

3 Answers 3

3 Comments

a.php

b.php

c.php

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

a.php

b.php

c.php

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related