Can't catch typescript error in typescript

Question

I can't catch the error. I deliberately messed up the query string to handle this case, but it still gets through. With developer tools open, the app crashes. I am using axios, redux-toolkit and typescript. Please tell me what should I do?

export const fetchUsers = createAsyncThunk(
    'user/fetchAll',
    async (_, {rejectWithValue}) => {
        try {
            const response = await axios.get<IUser[]>('https://jsonplaceholder.typicode.com/use2rs')
            return response.data
        } catch (e) {
            if (e instanceof Error) {
                return rejectWithValue(e.message)
            }

        }
    }
)

But when I use such a tool, everything works well. However, I'd like to use the convenience of createAsyncThunk and rejectWithValue


export const fetchUsers = () => async (dispatch: AppDispatch) => {
    try {
        dispatch(userSlice.actions.usersFetching())
        const response = await axios.get<IUser[]>('https://jsonplaceholder.typicode.com/users')
        dispatch(userSlice.actions.usersFetchingSuccess(response.data))
    } catch (e: any) {
        dispatch(userSlice.actions.usersFetchingError(e.message))
    }
}

phry · Accepted Answer · 2022-06-02 21:38:28Z

1

instanceof Error almost never works, since extending JavaScript-internal classes like Error can result in classes that technically do not keep the right property chain. This might differ depending on your transpilation target.

Better check something like typeof error.message == 'string' or write a little typeguard:

function hasMessage(e: any): e is {message: string} {
  return e && typeof e.message == 'string'
}

// ...

if (hasMessage(e)) return rejectWithValue(e.message)

edited Jun 2, 2022 at 21:38

answered Jun 2, 2022 at 21:11

phry

44.9k7 gold badges96 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

wannnwdooo Over a year ago

Sorry, I'm a total newbie, but where can I get the error field from the hasMessage function?

phry Over a year ago

Oh sorry, typo. Should be e.message. Let me fix it.

wannnwdooo Over a year ago

I just tried this, but when the developer tool is open, it still crashes

phry Over a year ago

You never mentioned any crash. Maybe add that to your question, with the full error message? This shouldn't have anything to do with crashing behaviour though

wannnwdooo Over a year ago

I'm sorry, I've corrected the description

|

Collectives™ on Stack Overflow

Can't catch typescript error in typescript

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related