Java Check if multiple strings are empty

Question

I am trying to add a User into a LinkedList using Java, but I am wondering if there is a shorter way to check if multiple strings are empty instead of using if statements everytime I input a new string

This is the method I came up with

    public void addUser() {
        int error = 0;
        
        do {
            Users user = new Users();
            String name = JOptionPane.showInputDialog(null, "Enter your name");
            if (name.isEmpty()) {
                error = 1;
            } else {
                String password = JOptionPane.showInputDialog(null, "Enter a password");
                if (password.isEmpty()) {
                    error = 1;
                } else {
                    // more string inputs
                }
            }

        } while (error != 0);
    }

You can avoid the nesting by skipping the else and calling continue; instead of relying on error. — shmosel
– shmosel, Commented Oct 14, 2022 at 19:04
Either you pass the loop one time or infinite, because you don't set error back to 0 at next loop (should happen at the beginning of the loop) — Christoph S.
– Christoph S., Commented Oct 14, 2022 at 20:01

Nowhere Man · Accepted Answer · 2022-10-14 18:56:13Z

1

Implement a separate method to read the input data until a valid string is provided and call this method with custom prompt:

private static String readInput(String prompt) {
    String input;
    do {
        input = JOptionPane.showInputDialog(null, prompt);
    } while (input == null || input.isEmpty());
}

public void addUser() {
    String name = readInput("Enter your name");
    String password = readInput("Enter a password");
// ...
    User user = new User(name, password, ...);
// ...
}

answered Oct 14, 2022 at 18:56

Nowhere Man

19.7k9 gold badges21 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

shmosel Over a year ago

Note that this doesn't restart the input loop on error, as it does in the question.

Binjie Liang Over a year ago

Thanks! This is what I was trying to look for!

Nowhere Man Over a year ago

@shmosel that loop is moved inside readInput method, and in the original implementation an error would cause to re-input all the fields from the start

shmosel Over a year ago

That's what I said

Collectives™ on Stack Overflow

Java Check if multiple strings are empty

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related