using a javascript variable

Question

I'm having trouble with this script recognizing my variable as a variable. The important part of the script is as follows:

    var content = 'imagereims';
    var ms = content.substring(5);
    $.get("../msimages/image.php", {ms: 'ms', pid: '<?php echo "$pid" ?>'}
    );

I want the script to recognize the variable ms as reims, but when the page displays it doesn't recognize the content of the variable. It just repeats ms. I've tried writing the variable without single quotes and with double quotes. I get the same result.

Any suggestions. Thanks

beatgammit · Accepted Answer · 2011-09-23 18:36:04Z

5

You'll want to leave off the quotes on 'ms'. Try this:

var content = 'imagesreims'
var ms = content.substring(4);
$.get("../msimages/image.php", {ms: ms, pid: '<?php echo "$pid" ?>'});

'ms' is saying use this string literal as the value.

You'll also want a different substring. Try content.substring(6). content.substring(4) will yield 'esreims'.

As mentioned in another answer, you missed the ); at the end, which I've included in my answer.

answered Sep 23, 2011 at 18:36

beatgammit

20.3k20 gold badges91 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Jeff Over a year ago

Well that was my initial thought; but no dice. Maybe I'm doing something wrong with the substring and the variable's empty.

beatgammit Over a year ago

The substring looks correct, but it won't give you what you are expecting. Like I mentioned, use a different substring. The code I gave seems to work (assuming your PHP code works correctly).

Saket · Accepted Answer · 2011-09-23 18:37:59Z

1

Here's what you would do:

var content = 'imagesreims'
var ms = content.substring(6);
$.get("../msimages/image.php", {ms: ms, pid: '<?php echo "$pid" ?>'}

Note two things:

use ms as the variable, rather than the literal 'ms'
correct index 4 to 6, if you want reims

answered Sep 23, 2011 at 18:37

Saket

46.3k13 gold badges65 silver badges80 bronze badges

1 Comment

Jeff Over a year ago

Perfect -- those were my two problems. Thanks.

Jonathan M · Accepted Answer · 2011-09-23 18:37:29Z

1

Current your line:

var ms = content.substring(4);

is assigning ms the value esreims. See documentation here: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/String/substring

All of these answers have pointed out errors in the code. You'll want to draw from them all.

answered Sep 23, 2011 at 18:37

Jonathan M

17.5k9 gold badges61 silver badges95 bronze badges

Collectives™ on Stack Overflow

using a javascript variable

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related