Make array with arrays from a mysql query

Question

Working on a e-shop, i must read from the DB the products that have productpack not null.

productpack from the DB looks like this : 0141,3122,0104,0111,3114,0106,0117 .

I'm trying to get all the DB items that have productpack set (not null), and make them into an array with arrays with those codes (0141,3122,0104,0111,3114,0106,0117).

function p_productpacks(){

    $productpacks = array();
    $pack = array();

    $q = mysql_query('SELECT productpack FROM products WHERE productpack <> "";');

    while($p = mysql_fetch_object($q)){

        $pack = explode(",", $p);

        $productpacks[] = $pack;

    }

    return $productpacks;

}

This looks like your database model isn't properly normalized. Whenever you feel the need to write your own little micro-database logic inside a database, something is off. — Kerrek SB
– Kerrek SB, Commented Oct 3, 2011 at 10:35

hakre · Accepted Answer · 2011-10-03 10:31:18Z

1

You need to create an array otherwise, you're overwriting existing packs:

$pack = explode(",", $p->productpack);

$productpacks[] = $pack;

For more information read about array_push^Docs and PHP Arrays ^Docs (and mysql_fetch_object^Docs).

answered Oct 3, 2011 at 10:31

hakre

200k55 gold badges454 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

hakre Over a year ago

So what's your question then?

mr.Liviu.V Over a year ago

well ... somehow it doesn't work, i don't know why. the array is empty

Gianluca Ghettini Over a year ago

well, it will not work as expected if comma is a valid character for a product pack name

Johan · Accepted Answer · 2011-10-03 10:39:06Z

0

You can get all productpacks in a CSV array using:

$result = mysql_query("SELECT GROUP_CONCAT(productpack) as productpacks
                       FROM products WHERE productpack <> '' ");
if ($result) {
  $row = mysql_fetch_row($result);
  $productpacks_as_CSV_string = $row['productpacks'];
}

That way you only need to get one row out of the database, saving lots of time.

See: http://dev.mysql.com/doc/refman/5.0/en/group-by-functions.html#function_group-concat

answered Oct 3, 2011 at 10:39

Johan

77.4k28 gold badges204 silver badges346 bronze badges

Comments

DaveyBoy · Accepted Answer · 2011-10-03 10:48:57Z

0

mysql_fetch_object returns an object and can't be used with string processing.. if you definitely want to use this, you need to do something like:

$pack=explode(',',$p->productpack);
$productpacks[]=$pack

Or, to use a good old array instead:

while ($p = mysql_query($q))
{
    $pack = explode(",", $p['productpack']);
    $productpacks[] = $pack;
}

edited Oct 3, 2011 at 10:48

answered Oct 3, 2011 at 10:43

DaveyBoy

2,9162 gold badges19 silver badges30 bronze badges

1 Comment

mr.Liviu.V Over a year ago

hmmm .. this seemsmore close to what i want to do... i will test this now .

Collectives™ on Stack Overflow

Make array with arrays from a mysql query

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related