php foreach submit button

Question

The issue I am having is that my form submit button, because it is within the foreach loop, ends up submitting for every single item that the foreach runs through. If I put it on the outside of the loop the submit does not have the correct number to submit, it ends up submitting the last value in the foreach. Does anyone have a solution for this?

    <div data-role='collapsible' data-collapsed='true' data-icon='arrow-l'>
        <h3><?=$ticket['ticket_no']?> - <?=$ticket['title']?></h3>

        <div class="ui-body ui-body-a"> 
            <ul data-role="listview" data-inset="true" data-theme="c" data-dividertheme="c">
            <li data-role="list-divider"><h1></h1></li> 
            <li><h3>Description</h3><br><br><?=$ticket['description'] ?></li>
            <input type=hidden name=ticket_number value=<?= $ticket['ticket_no'];  ?>>
            <form action="<?=$_SERVER['PHP_SELF']; ?>" method="post">
            <fieldset>
                <div data-role="fieldcontain">
                    <label for="status" class="select">Change Status:</label>
                    <select name="status" id="<?=$ticket['ticket_no']?>">
                        <option value="Open">Status</option>
                        <option value="Tracker">Tracker</option>
                        <option value="Abandon">Abandon</option>
                        <option value="Communicate">Communicate</option>
                        <option value="Closed">Closed</option>
                    </select>
                </div>
                <input type="submit" data-theme="a" name="submit" value="Submit"></input>
            </fieldset>
        </form>


        </div><!-- /themed container --> 
    </div> <!-- End inner collapsible set -->

} ?>

Cool coding style, the self-submitting form code ;) - the general answer is that you need to separate output and input processing from each other, see IPO Model. — hakre
– hakre, Commented Oct 5, 2011 at 18:54
why you are using html over here in loop? write it outside and then submit it with the php code. — Astha
– Astha, Commented Oct 5, 2011 at 18:56

David Houde · Accepted Answer · 2011-10-05 20:12:26Z

1

In each form, put something like:

<input type=hidden name=ticket_number value=<?= $ticket['ticket_no'];  ?>>

and then move your if() to outside of the loop, and check for $_POST['ticket_number']

if(isset($_POST['submit']) && isset($_POST['ticket_number'])) {
 $tickNum = $_POST['ticket_number'];
 updateTT($tickNum);                            
}

This was done with the least amount of change possible. Please sanitize your input, and all that good stuff!

edited Oct 5, 2011 at 20:12

answered Oct 5, 2011 at 18:58

David Houde

4,7881 gold badge22 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

David Houde Over a year ago

This is assuming you want a Submit button for each ticket, and this isnt a single large form. If this is 1 large form, this is the wrong approach. If you want to list all your tickets on one page, but need to preform actions on each one individually, then use this method...

lockdown Over a year ago

This is on the right track, but the form submit still does not correctly match with the ticket number. Itends up still submitting the very last foreach item.

David Houde Over a year ago

I had to change the code, I was using $_POST['status'] to get the ticket number, but this is set as the ID, and not the VALUE. Try the above code instead, adding the hidden form element. This should work, otherwise post resived code.

lockdown Over a year ago

Snagged the issue, i put the hidden input outside of the form. It is now corrected. Thank you David.

Lee Price · Accepted Answer · 2011-10-05 18:54:48Z

0

move the <form> tags from the loop as well as the button, that should work for you

answered Oct 5, 2011 at 18:54

Lee Price

5,21211 gold badges36 silver badges36 bronze badges

Comments

Momen Zalabany · Accepted Answer · 2011-10-05 19:02:38Z

0

the problem you are currently overwriting your fields as they have same name.

[] is what you need !.

<select name="status[]" id="<?=$ticket['ticket_no']?>">
                            <option value="Open">Status</option>
                            <option value="Tracker">Tracker</option>
                            <option value="Abandon">Abandon</option>
                            <option value="Communicate">Communicate</option>
                            <option value="Closed">Closed</option>
</select>

now after you post u will get all tickets in status array. when u receive status loop it to get each value.

example of array post : http://www.pickndrive.info/questions.php

check the form html for example

answered Oct 5, 2011 at 19:02

Momen Zalabany

9,03616 gold badges81 silver badges144 bronze badges

2 Comments

David Houde Over a year ago

This is assuming he wants to submit everything on the page. It appears to me that he wants a submit button for each ticket.

Momen Zalabany Over a year ago

@David thank u for highlighting . he said "it ends up submitting the last value in the foreach" so i figured he need to submit all of them. well if he need to submit everything that code, else then his code shall works fine !

Collectives™ on Stack Overflow

php foreach submit button

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related