php sql insert multiple

Question

Im trying to convert data from one table to another, from the ITEMS_VEHICLES table to the VEHICLES table. My code is this:

$sql_result = mysql_query("SELECT * FROM items_vehicles", $db); 
while ($rs = mysql_fetch_array($sql_result)) {
    if ($rs[motorbike] > 0) { mysql_query("INSERT INTO vehicles (type, player, hp) VALUES('1', '$rs[player]', '50')"); }
    if ($rs[banger] > 0) { mysql_query("INSERT INTO vehicles (type, player, hp) VALUES('2', '$rs[player]', '50')"); 
}

etc

But the $rs[motorbike] and other fields i want them to insert that code the amount of times in that column. Example, if $rs[motorbike] was '5', I want that insert query ran 5 times.

I'm in a bind, not sure how to do it.

This: '$rs[player]' should be '{$rs[player]}' or '".$rs[player]."'. You should also avoid using inherent strings (such as $rs[player], see player) and instead use quoted strings like '{$rs["player"]}'. — Jared Farrish
– Jared Farrish, Commented Nov 25, 2011 at 21:49
Please put quotes around your array keys, and turn on display_errors, as your code produces all sorts of notices you must not be seeing. $rs['motorbike'] — Michael Berkowski
– Michael Berkowski, Commented Nov 25, 2011 at 21:49
Your code as is will produce lots of notices like Notice: Use of undefined constant motorbike — Michael Berkowski
– Michael Berkowski, Commented Nov 25, 2011 at 21:51

Daren Chandisingh · Accepted Answer · 2011-11-25 21:50:36Z

2

Judging by your explanation, something like this:

$sql_result = mysql_query("SELECT * FROM items_vehicles", $db); 
while ($rs = mysql_fetch_array($sql_result)) {
    for ($i = 1; $i <= $rs['motorbike']; $i++) { 
        mysql_query("INSERT INTO vehicles (type, player, hp) VALUES('1', '$rs[player]', '50')"); 
    }
    for ($i = 1; $i <= $rs['banger']; $i++) { 
        mysql_query("INSERT INTO vehicles (type, player, hp) VALUES('2', '$rs[player]', '50')");    
    }
    etc
}

answered Nov 25, 2011 at 21:50

Daren Chandisingh

2,1631 gold badge13 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

user1022585 Over a year ago

thanks, what if i wanted a restriction of 5 max on each one, is that hard to edit?

Daren Chandisingh Over a year ago

for ($i = 1; $i <= min(5, $rs['motorbike']); $i++)

Daren Chandisingh Over a year ago

Is it running more than once for the same user? e.g. once with $rs['motorbike'] set to 4 and another with it set to 2, for example? That would make 6 in total, because each time it runs the number is less than 5. If not that, I don't know why it's not working. min(5, $rs['motorbike']) should return the minimum value of either 5 or $rs['motorbike'].

user1022585 Over a year ago

oh, i want it to either be $rs[motorbike] or 5 max. So if rs[motorbike] is over 5, then it just stops, 5 being max.

Daren Chandisingh Over a year ago

Yes, so you want the minimum of 5 and $rs['motorbike']; but if there is more than one record for a given user, he might still end up with more than 5 doing it that way.

Nightfirecat · Accepted Answer · 2012-11-13 02:03:40Z

0

Replace your if statements with a for loop that runs x times, where x is the size of $rs['motorbike'].

edited Nov 13, 2012 at 2:03

Nightfirecat

11.6k6 gold badges37 silver badges53 bronze badges

answered Nov 25, 2011 at 21:48

Julien

3103 gold badges20 silver badges56 bronze badges

Collectives™ on Stack Overflow

php sql insert multiple

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related