Javascript string within a string

Question

I'm very new to this, so I'm sorry if I cant explain myself properly. I'm running a website with a lightbox for images, inside the lightbox I embeded a link and what I want to do is that link to open a new pop-up window, but I've encountered a small problem on my code:

<a href="images/gallery/1.jpg" class="lytebox" data-title="<br /><a href='javascript:popUp('images/junk1.php')'/>Add a Comment</a>">
    <img src="images/thumbnails/1.jpg" border="0">
</a>

You see, when I get to the 'javascript:popUp('images/junk1.php')' I've already used the apostrophes, so it doesn't load. I've been reading about strings being within strings and I've tried escaping it via \ but it doesn't work. Any help?

Embedding HTML like that is really horrid. Why not embed some data instead (like perhaps just images/junk1.php) and let a script take care of the rest of the content generation? — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Dec 4, 2011 at 18:49
No idea of what Tomalak's talking about. I know it's horrid. I've taken like 3 classes of php, I don't know much about this, and I need this for a test, that's all. — Mariana Gatos
– Mariana Gatos, Commented Dec 4, 2011 at 19:52
This question is similar to: How do I properly escape quotes inside HTML attributes?. If you believe it’s different, please edit the question, make it clear how it’s different and/or how the answers on that question are not helpful for your problem. — dumbass
– dumbass, Commented Jan 7 at 8:00

Matt Ball · Accepted Answer · 2011-12-04 18:46:23Z

1

Use HTML entities. Something like this (not tested):

data-title="&lt;br /&gt;&lt;a href=&quot;javascript:popUp('images/junk1.php')&quot;/&gt;Add a Comment&lt;/a&gt;"

answered Dec 4, 2011 at 18:46

Matt Ball

361k102 gold badges655 silver badges725 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

rlemon · Accepted Answer · 2011-12-04 18:48:35Z

0

ok.. how about you just change the call around a little.. not sure if this will work, but you could give it a try.

<a href="images/gallery/1.jpg" class="lytebox" data-title="<br /><a data-img='images/junk1.php' onclick='popUp(this.dataset.img)'/>Add a Comment</a>"><img src="images/thumbnails/1.jpg" border="0"></a>

or you can do as rob suggests...

<a href="images/gallery/1.jpg" class="lytebox" data-title="<br /><a href='javascript:popUp(&quot;images/junk1.php&quot;)'/>Add a Comment</a>">
    <img src="images/thumbnails/1.jpg" border="0">
</a>

edited Dec 4, 2011 at 18:48

answered Dec 4, 2011 at 18:42

rlemon

17.7k14 gold badges95 silver badges126 bronze badges

2 Comments

Rob W Over a year ago

Your answer would be OK if you replace \" with " (<---Answer to question here).

rlemon Over a year ago

ahh, i see your solution is probably better.

Collectives™ on Stack Overflow

Javascript string within a string

2 Answers 2

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related