Split string into array then loop, in C#

Question

I have Googled this a LOT but my C# skills are pretty terrible and I just can't see why this isn't working.

I have a string which comes from a session object, which I don't have any control over setting. The string contains some sentences separated by six underscores. e.g.:

Sentence number one______Sentence number two______Sentence number three etc

I want to split this string by the six underscores and return each item in the resultant array.

Here's the code I have:

string itemsPlanner = HttpContext.Current.Session["itemsPlanner"].ToString();

string[] arrItemsPlanner = itemsPlanner.Split(new string[] { "______" }, StringSplitOptions.None);

foreach (string i in arrItemsPlanner)
{
  newItemsPlanner += "debug1: " + i;  //This returns what looks like a number, as I'd expect, starting at zero and iterating by one each loop.
  int itemNumber;

  try
  {
    itemNumber = Convert.ToInt32(i);
    string sentence = arrItemsPlanner[itemNumber].ToString();
  }
  catch (FormatException e)
  {
    return "Input string is not a sequence of digits.";
  }
  catch (OverflowException e)
  {
    return "The number cannot fit in an Int32.";
  }
  finally 
  {
    return "Fail!"
  }
}

Whenever I run this, the session is being retreived successfully but the line which says: itemNumber = Convert.ToInt32(i); fails every time and I get an error saying "Input string is not a sequence of digits."

Can anyone point me in the right direction with this please?

Many thanks!

Can you provide some sample of your session string? Try trim Convert.ToInt32(i.Trim()). — Amar Palsapure
– Amar Palsapure, Commented Jan 5, 2012 at 9:08
Post sample value for itemsPlanner - is it something like 1______6______1? — user447356
– user447356, Commented Jan 5, 2012 at 9:08
If your input string was 324534______1162______12432 instead of "sentences" then your question would make more sense. Also, why are you converting to an integer then back to a string? What are you trying to do? — Mark Byers
– Mark Byers, Commented Jan 5, 2012 at 9:08

user1105802 · Accepted Answer · 2012-01-05 09:10:31Z

5

If you just want to get each sentence and do something with it, this will do the trick:

string itemsPlanner = HttpContext.Current.Session["itemsPlanner"].ToString(); 
string[] arrItemsPlanner = itemsPlanner.Split("______"); 

foreach (string i in arrItemsPlanner) 
{ 
  // Do something with each sentence
}

You can split over a string as well as char (or char[]). In the foreach 'i' will be the value of the sentence, so you can concatenate it or process it or do whatever :)

If I've misunderstood, my apologies. I hope that helps :)

answered Jan 5, 2012 at 9:10

user1105802

Sign up to request clarification or add additional context in comments.

Comments

Øyvind Bråthen · Accepted Answer · 2012-01-05 09:08:50Z

4

in your case i is not a number, it's the actual element in the array. A foreach loop has no iteration variable, you only have access to the actual element being iterated through i.

So first loop itareation i is Sentence number one, then Sentence number two.

If you want the number, you have to use a for loop instead.

So something like this

for( int i = 0; i < arrItemsPlanner.length; i++ ){
  //on first iteration here
  //i is 0
  //and arrItemsPlanner[i] id "Sentence number one"
}

Hope it helps.

answered Jan 5, 2012 at 9:08

Øyvind Bråthen

60.9k28 gold badges128 silver badges154 bronze badges

Comments

Dario Solera · Accepted Answer · 2012-01-05 09:09:52Z

1

From your example i does not contain a valid integer number, thus Convert.ToInt32 fails. The foreach loop sets i with the current item in the sentences array, so basically i always contains one of the sentences in your main string. If you want i to be the index in the array, use a for loop.

answered Jan 5, 2012 at 9:09

Dario Solera

5,8443 gold badges32 silver badges35 bronze badges

Comments

Shiplu Mokaddim · Accepted Answer · 2012-01-05 09:10:16Z

1

Example from MSDN.

    string words = "This is a list of words______with a bit of punctuation" +
                   "______a tab character.";

    string [] split = words.Split(new Char [] {'_'}, StringSplitOptions.RemoveEmptyEntries);

    foreach (string s in split) {

        if (s.Trim() != "")
            Console.WriteLine(s);
    }

answered Jan 5, 2012 at 9:10

Shiplu Mokaddim

57.8k20 gold badges147 silver badges193 bronze badges

Comments

Paul · Accepted Answer · 2012-01-05 09:11:36Z

1

Do you need to trim your string before converting to a number? if thats not you may want to use Int32.tryParse()

answered Jan 5, 2012 at 9:11

Paul

1,47315 silver badges32 bronze badges

Comments

Alok · Accepted Answer · 2012-01-05 09:19:54Z

1

In your sample code foreach (string i in arrItemsPlanner) 'i' will get the string value of arrItemsPlanner one by one. For exmaple on first iteration it will have 'Sentence number one' which is obviously not a vlid ont, hence your conversion failed.

answered Jan 5, 2012 at 9:19

Alok

2742 silver badges15 bronze badges

Comments

Guillaume Slashy · Accepted Answer · 2012-01-05 09:17:38Z

0

i only contains one of the string fragment which will be : number one Sentence number two and Sentence number three. If you want it to contain an int representing ht index, use : 1) a for loop 2) an int defined before your foreach and increase it (myInt++) in the foreach code !

answered Jan 5, 2012 at 9:17

Guillaume Slashy

3,6448 gold badges47 silver badges70 bronze badges

Collectives™ on Stack Overflow

Split string into array then loop, in C#

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related