Function not getting called in JavaScript

Question

Following is my javascript code. The problem is when I call the send() function it doesnt really respond because x, y and z because they are local variables. I have tried making them global using a few approaches like creating an object but all have failed. Anybody here knows a proper approach to do that?

<script type='text/javascript'>
  function store(x,y,z) {           
      var date = x+" "+y+" "+z;
      document.getElementById("date").value=date;
  }
  function send(){
      var events=document.getElementById("event").value;
      location.href="q.php?day=" + x + "&month=" + y + "&year=" + z;        
  }
</script>

Would appreciate if you could post more code. How you define the variables. And how you call the function. Best from Jonas — Jonas m
– Jonas m, Commented Jan 30, 2012 at 8:25

Amar Palsapure · Accepted Answer · 2012-01-30 08:29:58Z

1

Try this, considering you are calling store function before send

<script type='text/javascript'>
   var xx, yy, zz; //These are your global variables
   function store(x,y,z) {   
      xx = x;
      yy = y;
      zz = z;          
      var date = x + " " + y + " " + z;
      document.getElementById("date").value = date;
   }

   function send(){
      var events = document.getElementById("event").value;
      location.href="q.php?day=" + xx + "&month=" + yy + "&year=" + zz;      
   }
</script>

edited Jan 30, 2012 at 8:29

answered Jan 30, 2012 at 8:24

Amar Palsapure

9,6561 gold badge29 silver badges46 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Guffa · Accepted Answer · 2012-01-30 08:39:53Z

1

You can create the URL in the store function, then you only need one global variable:

<script type='text/javascript'>

  var url;

  function store(x, y, z) {           
    var date = x + " " + y + " " + z;
    document.getElementById("date").value = date;
    url = "q.php?day=" + x + "&month=" + y + "&year=" + z;
  }

  function send(){
    var events = document.getElementById("event").value;
    location.href = url;
  }

</script>

answered Jan 30, 2012 at 8:39

Guffa

703k111 gold badges760 silver badges1k bronze badges

Comments

Hemant Metalia · Accepted Answer · 2012-01-30 08:50:02Z

0

change the name of function send and store

<script type='text/javascript'>
    var xGlobal,yGlobal,zGlobal;
    function mystore(x,y,z) {      
        xGlobal=x;
        yGlobal=y;
        zGlobal=z;       
        var date = x+" "+y+" "+z;

        document.getElementById("date").value=date;
    }

    function mysend(){
        var events=document.getElementById("event").value;
        location.href="q.php?day=" + xGlobal + "&month=" + yGlobal + "&year=" + zGlobal;      
    }
</script>

see the example in fiddle

edited Jan 30, 2012 at 8:50

answered Jan 30, 2012 at 8:33

Hemant Metalia

30.8k18 gold badges77 silver badges93 bronze badges

Collectives™ on Stack Overflow

Function not getting called in JavaScript

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related